Fix fraction dropping leading zeros - #11
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes incorrect handling of fractional seconds where leading zeros were being dropped (e.g., interpreting .05 as .5) by preserving the fraction digits verbatim as a string throughout parsing and conversions.
Changes:
- Change
types.Time.fractionfromint | Nonetostr | Noneand document why the digits are preserved verbatim. - Update
_cast_timeto keep the captured fraction substring instead of casting it toint. - Update and extend tests to ensure fraction width/leading zeros are preserved and remain semantically significant.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
gedcom7/types.py |
Updates Time.fraction type to `str |
gedcom7/cast.py |
Preserves the fraction group as a string when casting time values. |
test/test_util.py |
Updates fraction inputs to strings and adds a test asserting leading-zero significance. |
test/test_cast.py |
Updates time-casting expectations and adds a test for preserving fraction text width. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.