Skip to content

JSON Output + Gradient Modal Improvements - #60

Merged
Silabear merged 12 commits into
mainfrom
gradient-improvements
Aug 10, 2026
Merged

JSON Output + Gradient Modal Improvements#60
Silabear merged 12 commits into
mainfrom
gradient-improvements

Conversation

@Silabear

Copy link
Copy Markdown
Contributor
  • Added JSON output type on the other output formats screen
  • Added an option to output item lore as JSON
  • Added "Recent Gradients" page which stores up to 10 recent gradients
  • You can now rearrange gradient steps in the editor

@Silabear
Silabear requested a review from HoodieRocks August 10, 2026 17:00

@HoodieRocks HoodieRocks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no serious issues I've seen, so my comments are just nitpicks

Comment thread src/lib/components/modals/topbar/ExportModal.svelte Outdated
Comment thread src/lib/components/modals/ColorGradientModal.svelte Outdated
if (onOpen) {
onOpen();
}
await tick();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDK who did this change (might have been me for all i know) but is there a reason this is being rearranged?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not to my knowledge, not sure why. but i think it all still works now?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my understanding the changes in this file could have probably been separate test cases instead of modify the originals

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically, but the old tests would always fail because i moved the code which adds the L to the translate function, which also messes with the output

Comment thread src/lib/components/modals/ColorGradientModal.svelte Outdated

@Silabear Silabear left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some changes

Comment thread src/lib/components/modals/ColorGradientModal.svelte Outdated
Comment thread src/lib/components/modals/ColorGradientModal.svelte Outdated

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically, but the old tests would always fail because i moved the code which adds the L to the translate function, which also messes with the output

if (onOpen) {
onOpen();
}
await tick();

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not to my knowledge, not sure why. but i think it all still works now?

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 10, 2026

Copy link
Copy Markdown

Deploying tools with  Cloudflare Pages  Cloudflare Pages

Latest commit: f985789
Status: ✅  Deploy successful!
Preview URL: https://35ac87e0.tellraw-aav.pages.dev
Branch Preview URL: https://gradient-improvements.tellraw-aav.pages.dev

View logs

@Silabear
Silabear merged commit 8eb2a18 into main Aug 10, 2026
8 checks passed
@Silabear
Silabear deleted the gradient-improvements branch August 10, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants