Skip to content

๐ŸŽจ Palette: '์ ‘๊ทผ ๊ด€๋ฆฌ' ๋น„ํ™œ์„ฑํ™” ๋ฒ„ํŠผ ์ ‘๊ทผ์„ฑ ๊ฐœ์„  (aria-disabled ํŒจํ„ด) - #970

Open
seonghobae wants to merge 7 commits into
mainfrom
palette-aria-disabled-export-modal-12786376928804229987
Open

๐ŸŽจ Palette: '์ ‘๊ทผ ๊ด€๋ฆฌ' ๋น„ํ™œ์„ฑํ™” ๋ฒ„ํŠผ ์ ‘๊ทผ์„ฑ ๊ฐœ์„  (aria-disabled ํŒจํ„ด)#970
seonghobae wants to merge 7 commits into
mainfrom
palette-aria-disabled-export-modal-12786376928804229987

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

๐Ÿ’ก What

  • ExportModal.tsx์˜ '์ ‘๊ทผ ๊ด€๋ฆฌ' ๋ฒ„ํŠผ์— ์‚ฌ์šฉ๋œ ๋„ค์ดํ‹ฐ๋ธŒ disabled ์†์„ฑ์„ ์ œ๊ฑฐํ•˜๊ณ  aria-disabled="true" ํŒจํ„ด์„ ์ ์šฉํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ๋ฒ„ํŠผ์ด ํด๋ฆญ๋  ๋•Œ ์•„๋ฌด ๋™์ž‘๋„ ํ•˜์ง€ ์•Š๋„๋ก onClick={(e) => e.preventDefault()} ํ•ธ๋“ค๋Ÿฌ๋ฅผ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ExportModal.test.tsx์˜ Vitest ํ…Œ์ŠคํŠธ ์ฝ”๋“œ์—์„œ ํ•ด๋‹น ๋ฒ„ํŠผ์— ๋Œ€ํ•œ ๊ฒ€์ฆ์„ .toBeDisabled()์—์„œ .toHaveAttribute('aria-disabled', 'true')๋กœ ์ˆ˜์ •ํ•˜๊ณ , ํฌ์ปค์Šค๋ฅผ ๋ฐ›์„ ์ˆ˜ ์žˆ๋Š”์ง€ .toHaveFocus()๋กœ ํ™•์ธํ•˜๋„๋ก ๋ณด์™„ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • .Jules/palette.md์— ๋™์ ์œผ๋กœ ๋น„ํ™œ์„ฑํ™”๋˜๋Š” ๋ฒ„ํŠผ์˜ ๋ถ€๊ฐ€์ ์ธ ์„ค๋ช…์„ ์Šคํฌ๋ฆฐ ๋ฆฌ๋”์—์„œ ์ฝ์„ ์ˆ˜ ์žˆ๊ฒŒ ํ•˜๋Š” aria-disabled ํŒจํ„ด์— ๋Œ€ํ•œ ํ•™์Šต ๋‚ด์šฉ์„ ๊ธฐ๋กํ–ˆ์Šต๋‹ˆ๋‹ค.

๐ŸŽฏ Why

  • ๊ธฐ์กด์ฒ˜๋Ÿผ ๋„ค์ดํ‹ฐ๋ธŒ disabled ์†์„ฑ์„ ์‚ฌ์šฉํ•˜๋ฉด ํƒญ ์ด๋™(Tab sequence) ๋Œ€์ƒ์—์„œ ์ œ์™ธ๋˜์–ด, ํ‚ค๋ณด๋“œ ์ „์šฉ ์‚ฌ์šฉ์ž๋‚˜ ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ์‚ฌ์šฉ์ž๊ฐ€ ํ•ด๋‹น ๋ฒ„ํŠผ์— ํฌ์ปค์Šค๋ฅผ ๋‘˜ ์ˆ˜ ์—†์Šต๋‹ˆ๋‹ค.
  • ์ด๋กœ ์ธํ•ด ๋ฒ„ํŠผ ํ•˜๋‹จ์— ์—ฐ๊ฒฐ๋œ aria-describedby="share-export-access-hint"("์ ‘๊ทผ ๊ถŒํ•œ ๊ด€๋ฆฌ๋Š” ํ”„๋กœ์ ํŠธ ๊ถŒํ•œ ์„ค์ •์—์„œ ์ฒ˜๋ฆฌํ•ฉ๋‹ˆ๋‹ค.")๋ผ๋Š” ์ค‘์š”ํ•œ ๋งฅ๋ฝ ํžŒํŠธ๋ฅผ ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ์‚ฌ์šฉ์ž๊ฐ€ ์ „ํ˜€ ์ธ์ง€ํ•  ์ˆ˜ ์—†๋Š” ๋ฌธ์ œ๊ฐ€ ๋ฐœ์ƒํ•ฉ๋‹ˆ๋‹ค.

๐Ÿ“ธ Before/After

  • Before: '์ ‘๊ทผ ๊ด€๋ฆฌ' ๋ฒ„ํŠผ์ด disabled ์†์„ฑ์„ ๊ฐ€์ ธ์„œ ํ‚ค๋ณด๋“œ ์‚ฌ์šฉ์ž๊ฐ€ ์ ‘๊ทผํ•  ์ˆ˜ ์—†๊ณ  ๋ถ€๊ฐ€ ์„ค๋ช…์ด ์ƒ๋žต๋จ.
  • After: '์ ‘๊ทผ ๊ด€๋ฆฌ' ๋ฒ„ํŠผ์— aria-disabled="true"๋ฅผ ์‚ฌ์šฉํ•˜์—ฌ ๊ธฐ๋Šฅ์ ์œผ๋กœ๋Š” ๋น„ํ™œ์„ฑํ™”๋œ ์ƒํƒœ๋ฅผ ์œ ์ง€ํ•˜๋˜, ํฌ์ปค์Šค๋ฅผ ๋ฐ›์„ ์ˆ˜ ์žˆ์–ด ์—ฐ๊ฒฐ๋œ aria-describedby ํžŒํŠธ๋ฅผ ์ •์ƒ์ ์œผ๋กœ ์ฝ์–ด์ค„ ์ˆ˜ ์žˆ์Œ.

โ™ฟ Accessibility

  • ํ‚ค๋ณด๋“œ ๋‚ด๋น„๊ฒŒ์ด์…˜ ์‚ฌ์šฉ์ž์™€ ์Šคํฌ๋ฆฐ ๋ฆฌ๋”(Screen Reader) ์‚ฌ์šฉ์ž ๋ชจ๋‘ '์ ‘๊ทผ ๊ด€๋ฆฌ' ๋ฒ„ํŠผ์ด ์™œ ๋น„ํ™œ์„ฑํ™”๋˜์–ด ์žˆ๋Š”์ง€, ๊ทธ๋ฆฌ๊ณ  ์–ด๋””์„œ ๊ถŒํ•œ์„ ์„ค์ •ํ•ด์•ผ ํ•˜๋Š”์ง€์— ๋Œ€ํ•œ ์•ˆ๋‚ด ๋ฉ”์‹œ์ง€๋ฅผ ์ธ์ง€ํ•˜๊ณ  ๋“ค์„ ์ˆ˜ ์žˆ๊ฒŒ ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.
  • ์ด ๋ฐฉ์‹์€ UI ์ƒ์œผ๋กœ๋Š” ๊ธฐ์กด๊ณผ ๋™์ผํ•œ ํ˜•ํƒœ(opacity ๋“ฑ ๋น„ํ™œ์„ฑํ™” ์Šคํƒ€์ผ ์ ์šฉ)๋ฅผ ๋ ๋ฉด์„œ๋„ ์ ‘๊ทผ์„ฑ ํŠธ๋ฆฌ๋ฅผ ์˜จ์ „ํ•˜๊ฒŒ ๋ณด์กดํ•˜๋Š” ๋ชจ๋ฒ” ์‚ฌ๋ก€์ž…๋‹ˆ๋‹ค.

PR created automatically by Jules for task 12786376928804229987 started by @seonghobae


Open in Devin Review

Summary by CodeRabbit

  • ์ ‘๊ทผ์„ฑ ๊ฐœ์„ 

    • ๊ณต์œ  ๋งํฌ ์ ‘๊ทผ ๊ด€๋ฆฌ ๋ฒ„ํŠผ์ด ํ‚ค๋ณด๋“œ ํฌ์ปค์Šค๋ฅผ ์œ ์ง€ํ•˜๋ฉด์„œ๋„ ๋น„ํ™œ์„ฑ ์ƒํƒœ์ž„์„ ์Šคํฌ๋ฆฐ ๋ฆฌ๋”์— ์ „๋‹ฌํ•˜๋„๋ก ๊ฐœ์„ ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.
    • ๋น„ํ™œ์„ฑ ๋ฒ„ํŠผ์˜ ํด๋ฆญ ๋™์ž‘์ด ์‹คํ–‰๋˜์ง€ ์•Š๋„๋ก ์ฒ˜๋ฆฌํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ๋ฌธ์„œ

    • ๋™์ ์œผ๋กœ ๋น„ํ™œ์„ฑํ™”๋˜๋Š” ๋ฒ„ํŠผ๊ณผ ์„ค๋ช… ํžŒํŠธ์˜ ์ ‘๊ทผ์„ฑ ์ง€์นจ์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.

@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

Next included review available in 29 minutes.

View limit details

Limit details: Youโ€™ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

โš™๏ธ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 54c1b7d8-fc00-42c1-99b2-87dfc9278132

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between 037a690 and cc2d265.

๐Ÿ“’ Files selected for processing (3)
  • .Jules/palette.md
  • frontend/src/components/modals/ExportModal.test.tsx
  • frontend/src/components/modals/ExportModal.tsx
๐Ÿ“ Walkthrough

Walkthrough

ExportModal์˜ ์ ‘๊ทผ ๊ด€๋ฆฌ ๋ฒ„ํŠผ์ด disabled ๋Œ€์‹  aria-disabled="true"๋ฅผ ์‚ฌ์šฉํ•ฉ๋‹ˆ๋‹ค. ํด๋ฆญ ๋ฐฉ์ง€ ์ฒ˜๋ฆฌ๋ฅผ ์ถ”๊ฐ€ํ•˜๊ณ , ํฌ์ปค์Šค ๊ฐ€๋Šฅ ์ƒํƒœ๋ฅผ ํ…Œ์ŠคํŠธํ•ฉ๋‹ˆ๋‹ค. ๊ด€๋ จ ์ ‘๊ทผ์„ฑ ํ•™์Šต ์ง€์นจ๋„ ์ถ”๊ฐ€ํ•ฉ๋‹ˆ๋‹ค.

Changes

์ ‘๊ทผ์„ฑ ๋ฒ„ํŠผ ์ƒํƒœ ๋ณ€๊ฒฝ

Layer / File(s) Summary
aria-disabled ๋ฒ„ํŠผ ๋™์ž‘๊ณผ ๊ฒ€์ฆ
frontend/src/components/modals/ExportModal.tsx, frontend/src/components/modals/ExportModal.test.tsx, .Jules/palette.md
์ ‘๊ทผ ๊ด€๋ฆฌ ๋ฒ„ํŠผ์—์„œ disabled๋ฅผ ์ œ๊ฑฐํ•˜๊ณ  aria-disabled="true"๋ฅผ ์„ค์ •ํ•ฉ๋‹ˆ๋‹ค. ํด๋ฆญ ์‹œ ๊ธฐ๋ณธ ๋™์ž‘์„ ๋ฐฉ์ง€ํ•ฉ๋‹ˆ๋‹ค. ํ…Œ์ŠคํŠธ๋Š” ๋ฒ„ํŠผ์˜ aria-disabled ์†์„ฑ๊ณผ ํฌ์ปค์Šค ๊ฐ€๋Šฅ ์ƒํƒœ๋ฅผ ํ™•์ธํ•ฉ๋‹ˆ๋‹ค. ์ ‘๊ทผ์„ฑ ์ง€์นจ์„ ์ถ”๊ฐ€ํ•ฉ๋‹ˆ๋‹ค.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ๐Ÿ”ต Low ยท up to 037a6

The button remains focusable and exposes its accessibility hint, but preventing the default action alone may not fully block activation in all event-handling paths. Add an explicit disabled-state guard before merging; the risk is localized and otherwise manageable.

Possibly related PRs

  • ContextualWisdomLab/pg-erd-cloud#675: ๋™์ผํ•œ ExportModal ๋ฒ„ํŠผ๊ณผ ํ…Œ์ŠคํŠธ๋ฅผ aria-disabled ๋ฐฉ์‹์œผ๋กœ ๋ณ€๊ฒฝํ•ฉ๋‹ˆ๋‹ค.
๐Ÿšฅ Pre-merge checks | โœ… 5
โœ… Passed checks (5 passed)
Check name Status Explanation
Description Check โœ… Passed Check skipped - CodeRabbitโ€™s high-level summary is enabled.
Title check โœ… Passed ์ œ๋ชฉ์€ '์ ‘๊ทผ ๊ด€๋ฆฌ' ๋ฒ„ํŠผ์˜ ์ ‘๊ทผ์„ฑ ๊ฐœ์„ ๊ณผ aria-disabled ํŒจํ„ด์ด๋ผ๋Š” ์ฃผ์š” ๋ณ€๊ฒฝ ์‚ฌํ•ญ์„ ๋ช…ํ™•ํ•˜๊ฒŒ ์„ค๋ช…ํ•ฉ๋‹ˆ๋‹ค.
Docstring Coverage โœ… Passed Docstring check was indeterminate for this PR โ€” some files could not be analyzed in time. Not blocking.
Linked Issues check โœ… Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check โœ… Passed Check skipped because no linked issues were found for this pull request.
โœจ Finishing Touches
๐Ÿ“ Generate docstrings
  • Create stacked PR
  • Commit on current branch
๐Ÿงช Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette-aria-disabled-export-modal-12786376928804229987

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share

Comment @coderabbitai help to get the list of available commands.

devin-ai-integration[bot]

This comment was marked as resolved.

chatgpt-codex-connector[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant