feat(workspace): name tonight's first solo plan on the map - #1020
feat(workspace): name tonight's first solo plan on the map#1020seonghobae wants to merge 26 commits into
Conversation
Name the corroborated Keyboard 1 Right Hand verse solo at 0:10 so Open moves to the matching rendered map section. Fail closed on inherited, accessor, or Proxy-substituted runtime metadata. Do not invent solo copy from groove, cue, simplification, overlap, range, chords, function labels, setup notes, transposition, fill, tuning, dynamics, articulation, hook, confirmed overrides, harmonic explanations, or confidence notes.
📝 WalkthroughWalkthrough첫 솔로 계획 데이터를 공유 타입에 추가했습니다. 안전한 계획 해석기와 워크스페이스 콜아웃을 구현했습니다. 콜아웃은 소유 렌더러의 섹션 ID로 이동합니다. 영어·한국어 번역과 런타임 검증을 추가했습니다. Changes첫 솔로 계획
Estimated code review effort: 4 (Complex) | ~60 minutes Merge Risk: 🟡 Moderate · up to This PR adds buyer-visible first-solo guidance and exact map navigation, but the current implementation can still accept exotic role metadata objects as trusted authority, which may surface incorrect solo guidance to customers. Merge should wait for that validation issue to be fixed; the remaining documentation follow-up is minor. Sequence Diagram(s)sequenceDiagram
participant Workspace
participant FirstSoloPlanCallout
participant resolveFirstSoloPlan
participant SectionRoadmap
Workspace->>FirstSoloPlanCallout: song 전달
FirstSoloPlanCallout->>resolveFirstSoloPlan: 첫 솔로 계획 해석 요청
resolveFirstSoloPlan-->>FirstSoloPlanCallout: 소유 역할, 섹션 ID, 시작 시간 반환
FirstSoloPlanCallout->>SectionRoadmap: 일치하는 data-section-id 탐색
SectionRoadmap-->>FirstSoloPlanCallout: 단일 섹션 대상 반환
FirstSoloPlanCallout->>SectionRoadmap: reduced-motion 설정에 따라 scrollIntoView 실행
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 80.56% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 36 functions across 23 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Product outcome
The mounted rehearsal workspace names tonight's first corroborated solo so a part can lock the owned run before the rest of the band comes back in. Open Keyboard 1 Right Hand solo at 0:10 moves to the exact stable map section; ambiguous or missing authority stays fail-closed on tonight's map with next-action guidance.
Exact current identity
develop@acdbea6344fe1231c39535b575f4de35e4c607c9.4be3ae300fdb1b75c42da9000c189014c599e5d1.948e5c65c53cdba42bd7f8963fdbf7f06e1a8147.feat/workspace-first-solo-plan.Scope and runtime authority
soloPlanauthority requires an active corroborated role, canonical labeled section, bounded time, owned role identity/display/priority, and owned single-line solo copy.sectionIddata equality inside one unambiguous mounted workspace renderer; it does not use positionalsectionIndexauthority or selector interpolation.behavior: "auto"; Korean next-action copy remains particle-safe.Current-head verification
Repository-local workflows for exact head
4be3ae300fdb1b75c42da9000c189014c599e5d1:ci32825035986: success;release32825035902: success;build-baseline32825035894: success;sbom32825035931: success;SAST Semgrep32825035940: success;bandit32825035929: success;secret-scan-gate32825035897: success;security-audit32825035881: failure;Security Scan32825035861: failure.The exact
security-auditjob97731047810checked out merge-result948e5c65c53cdba42bd7f8963fdbf7f06e1a8147; its first failing step isnpm audit --workspaces --audit-level=high, reporting protected-basenanoid <3.3.18,pdfjs-dist >=5.6.83 <6.2.108, andundici 7.0.0-7.28.0HIGH advisories. This PR has no dependency/lock ownership, so those failures remain canonical #783 work and are not suppressed or worked around here.All current inline review threads are resolved. Formal reviews are COMMENTED only; there is no qualifying independent non-author exact-head approval.
Dependency / merge gate