Skip to content

feat(workspace): name tonight's first dynamics plan on the map - #1011

Open
seonghobae wants to merge 16 commits into
developfrom
feat/workspace-first-dynamics-plan
Open

feat(workspace): name tonight's first dynamics plan on the map#1011
seonghobae wants to merge 16 commits into
developfrom
feat/workspace-first-dynamics-plan

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

Buyer next action

The mounted rehearsal workspace names tonight's first dynamics plan so a part can lock the owned dynamics before rehearsal starts.

Demo: Bass Guitar still has Keep the verse under the vocal so the chorus still has somewhere to lift. Open is the next action: it moves to the matching rendered song-structure section.

Protected base: develop@acdbea6344fe1231c39535b575f4de35e4c607c9.
Exact current head: 10a651c024e5f4f7862139b29661c3802b748f30 on feat/workspace-first-dynamics-plan.

What the player sees

  • The callout names the owning part when an active graph node corroborates it, the owned dynamicsPlan copy, the labeled section, and the time.
  • Open scrolls the renderer-owned song-structure section and arms the next action: lock that dynamics before the room starts.
  • If no part owns rehearsal-facing dynamics copy, the card stays guidance-only. Stay on tonight's map.

Authority boundary and current-head repair

Exact-head verification state

Fresh repository workflows for 10a651c024e5f4f7862139b29661c3802b748f30 are queued/pending at the latest refetch. No non-terminal result and no predecessor-head evidence is counted as success.

Dependency / merge gate

  • fix(security): establish canonical npm, PDF.js, Nanoid, and Undici baseline #783 remains the canonical protected JavaScript dependency-security owner. Inherited pdfjs-dist / nanoid / undici HIGH findings are not copied or suppressed here. No lockfile change.
  • Keep unmerged until the unchanged current head has every applicable repository/central CI, cross-platform build, exact owned statement+branch coverage, docstring, SAST/security/SBOM/supply-chain/package/release gate terminal-success; zero valid unresolved findings; a qualifying independent non-author last-push approval; and ordinary branch-protection acceptance.
  • Queued, pending, skipped-required, cancelled, failed, predecessor-head, protected-base, model-only, self/author, or administrative-bypass evidence is not success.
  • Never bypass protection or transfer predecessor evidence. Do not self-approve.

Open in Devin Review

The mounted rehearsal workspace names tonight's first dynamics plan so a
part can lock the owned dynamics before rehearsal starts. Open moves to
the matching rendered song-structure section.

Do not invent that copy from groove, cue, simplification, overlap, range,
chord labels, function labels, setup notes, transposition plans, confirmed
overrides, harmonic explanations, or confidence notes. Distinct from
first-setup-note, first-transposition-plan, and first-tuning-plan.

Security Notes:
- Attack surface: untrusted rehearsal-song runtime metadata (sections,
  roles, partGraph, identity accessors) plus DOM navigation against the
  mounted song-structure renderer.
- Trust boundary: only own data properties on dense collections are read.
  Inherited/accessor/sparse/hostile getters fail closed to null and keep
  the callout guidance-only.
- Navigation authority is the renderer-owned section index, not analysis
  ids.
- Logging/privacy: no path, filename, or rejected-metadata echo.
- Test points: inherited-metadata suite, particle-safe Korean copy,
  reduced-motion scroll, workspace-scope renderer selection, Workspace
  navigation. Shared-types 20/20 at 100%. Desktop targeted 68/68.
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 16 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2cad91f4-7fb3-452d-8617-4dab3cee715a

📥 Commits

Reviewing files that changed from the base of the PR and between acdbea6 and f295265.

📒 Files selected for processing (28)
  • AGENTS.md
  • ARCHITECTURE.md
  • CHANGELOG.md
  • CLAUDE.md
  • apps/desktop/src/features/workspace/FirstDynamicsPlanCallout.identity.test.tsx
  • apps/desktop/src/features/workspace/FirstDynamicsPlanCallout.memoization.test.tsx
  • apps/desktop/src/features/workspace/FirstDynamicsPlanCallout.particle.test.tsx
  • apps/desktop/src/features/workspace/FirstDynamicsPlanCallout.reduced-motion.test.tsx
  • apps/desktop/src/features/workspace/FirstDynamicsPlanCallout.test.tsx
  • apps/desktop/src/features/workspace/FirstDynamicsPlanCallout.tsx
  • apps/desktop/src/features/workspace/FirstDynamicsPlanCallout.workspace-scope.test.tsx
  • apps/desktop/src/features/workspace/Workspace.test.tsx
  • apps/desktop/src/features/workspace/Workspace.tsx
  • apps/desktop/src/features/workspace/dynamicsCoverageContract.test.ts
  • apps/desktop/src/features/workspace/firstDynamicsPlan.inherited-metadata.test.ts
  • apps/desktop/src/features/workspace/firstDynamicsPlan.proxy-authority.test.ts
  • apps/desktop/src/features/workspace/firstDynamicsPlan.section-label.test.ts
  • apps/desktop/src/features/workspace/firstDynamicsPlan.test.ts
  • apps/desktop/src/features/workspace/firstDynamicsPlan.ts
  • apps/desktop/src/i18n/index.test.ts
  • apps/desktop/src/i18n/index.ts
  • apps/desktop/src/locales/en/common.json
  • apps/desktop/src/locales/ko/common.json
  • apps/desktop/vite.config.ts
  • docs/design-system/component-contract.md
  • docs/doctoring/reduced-motion-first-dynamics-plan-navigation.md
  • packages/shared-types/src/index.ts
  • packages/shared-types/test/index.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 new potential issues.

Open in Devin Review

Comment thread CHANGELOG.md Outdated
Comment thread apps/desktop/src/features/workspace/firstDynamicsPlan.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant