feat(workspace): name tonight's first harmonic function on the map - #1005
Open
seonghobae wants to merge 14 commits into
Open
feat(workspace): name tonight's first harmonic function on the map#1005seonghobae wants to merge 14 commits into
seonghobae wants to merge 14 commits into
Conversation
Surface owned harmony.functionLabel as the next rehearsal action so the room can lock the part function before starting. Open moves to the renderer-owned song-structure section. Do not invent that copy from groove, cue, simplification, overlap, range, chord labels, setup notes, confirmed overrides, harmonic explanations, or confidence notes.
Contributor
|
Warning Review limit reachedNext included review available in 44 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (24)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buyer next action
The mounted rehearsal workspace now names tonight's first harmonic function so the room can lock the owned part function before rehearsal starts.
Protected base:
develop@acdbea6344fe1231c39535b575f4de35e4c607c9.What the player sees
harmony.functionLabelcopy, the labeled section, and the time.Authority boundary
harmonicExplanation, or confidence notes.section.idis never DOM-ID authority.Docs
AGENTS.md, CLAUDE.md, ARCHITECTURE.md, CHANGELOG.md, and
docs/design-system/component-contract.mdname this next action. Reduced-motion Open usesbehavior: "auto".Dependency / merge gate
pdfjs-dist/nanoid/undiciHIGH findings are not copied or suppressed here.