Skip to content

feat(workspace): name tonight's first harmonic function on the map - #1005

Open
seonghobae wants to merge 14 commits into
developfrom
feat/workspace-first-harmonic-function
Open

feat(workspace): name tonight's first harmonic function on the map#1005
seonghobae wants to merge 14 commits into
developfrom
feat/workspace-first-harmonic-function

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

Buyer next action

The mounted rehearsal workspace now names tonight's first harmonic function so the room can lock the owned part function before rehearsal starts.

Protected base: develop@acdbea6344fe1231c39535b575f4de35e4c607c9.

What the player sees

  • The callout names the owning part when an active graph node corroborates it, the owned harmony.functionLabel copy, the labeled section, and the time.
  • Open scrolls the renderer-owned song-structure section and arms the next action: lock that function before the room starts.
  • If no part owns rehearsal-facing function copy, the card stays guidance-only. Stay on tonight's map.

Authority boundary

Docs

AGENTS.md, CLAUDE.md, ARCHITECTURE.md, CHANGELOG.md, and docs/design-system/component-contract.md name this next action. Reduced-motion Open uses behavior: "auto".

Dependency / merge gate

  • fix(security): establish canonical npm, PDF.js, Nanoid, and Undici baseline #783 remains the canonical protected JavaScript dependency-security owner. Inherited pdfjs-dist / nanoid / undici HIGH findings are not copied or suppressed here.
  • Keep unmerged until the unchanged then-current head has every applicable repository/central CI, cross-platform build, exact owned statement+branch coverage, docstring, SAST/security/SBOM/supply-chain/package/release gate terminal-success; zero valid unresolved findings; a qualifying independent non-author last-push approval; and ordinary branch-protection acceptance.

Open in Devin Review

Surface owned harmony.functionLabel as the next rehearsal action so the
room can lock the part function before starting. Open moves to the
renderer-owned song-structure section. Do not invent that copy from
groove, cue, simplification, overlap, range, chord labels, setup notes,
confirmed overrides, harmonic explanations, or confidence notes.
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 44 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c9573c19-9744-4b09-a07b-89621cfc6599

📥 Commits

Reviewing files that changed from the base of the PR and between acdbea6 and 6ea74e4.

📒 Files selected for processing (24)
  • AGENTS.md
  • ARCHITECTURE.md
  • CHANGELOG.md
  • CLAUDE.md
  • apps/desktop/src/features/workspace/FirstHarmonicFunctionCallout.accessibility.test.tsx
  • apps/desktop/src/features/workspace/FirstHarmonicFunctionCallout.particle.test.tsx
  • apps/desktop/src/features/workspace/FirstHarmonicFunctionCallout.reduced-motion.test.tsx
  • apps/desktop/src/features/workspace/FirstHarmonicFunctionCallout.sections-accessor.test.tsx
  • apps/desktop/src/features/workspace/FirstHarmonicFunctionCallout.test.tsx
  • apps/desktop/src/features/workspace/FirstHarmonicFunctionCallout.tsx
  • apps/desktop/src/features/workspace/FirstHarmonicFunctionCallout.workspace-scope.test.tsx
  • apps/desktop/src/features/workspace/Workspace.test.tsx
  • apps/desktop/src/features/workspace/Workspace.tsx
  • apps/desktop/src/features/workspace/firstHarmonicFunction.inherited-metadata.test.ts
  • apps/desktop/src/features/workspace/firstHarmonicFunction.proxy-authority.test.ts
  • apps/desktop/src/features/workspace/firstHarmonicFunction.test.ts
  • apps/desktop/src/features/workspace/firstHarmonicFunction.time-authority.test.ts
  • apps/desktop/src/features/workspace/firstHarmonicFunction.ts
  • apps/desktop/src/i18n/index.test.ts
  • apps/desktop/src/i18n/index.ts
  • apps/desktop/src/locales/en/common.json
  • apps/desktop/src/locales/ko/common.json
  • docs/design-system/component-contract.md
  • docs/doctoring/reduced-motion-first-harmonic-function-navigation.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant