Skip to content

fix(docs): restore README fence and unique-fold helper after #48 merge - #222

Closed
seonghobae wants to merge 3 commits into
mainfrom
cursor/readme-coverage-merge-repair-837b
Closed

fix(docs): restore README fence and unique-fold helper after #48 merge#222
seonghobae wants to merge 3 commits into
mainfrom
cursor/readme-coverage-merge-repair-837b

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

#48 merged 04f05ea4 before post-merge repairs landed. Protected main currently fails docs/coverage and has a duplicated architecture table.

This draft carries only those repairs:

  1. One balanced crate list of all 54 workspace members, including topic_measurement, analysis_engine, and psychometric_core.
  2. A single live load_union_branch_totals plus a test that unions True/False counts across instrumented copies.
  3. One location_membership, one validation_core, and one tepp_api row in the architecture foundation table, keeping terminal-result wording on the API row.

Does not change estimator contracts, lexical-weight labels, membership-fold overflow behavior, or ADR numbering.

Test plan

  • python3 scripts/check_workspace_contract.py
  • python3 scripts/check_docstrings.py
  • python3 scripts/validate_documentation.py
  • python3 -m coverage run --branch -m unittest discover -s tests/quality -p 'test_*.py'
  • python3 -m coverage report --fail-under=100 --show-missing (1336/662)

Exact-head GitHub CI still required. Independent OpenCode APPROVE remains an org gate; this PR stays draft until that path is available.

Open in Web Open in Cursor 

cursoragent and others added 2 commits August 25, 2026 02:47
The #49/#58/#65 merge reopened a second text fence and left historical
crate-list fragments inside Current implementation state. Keep one even
fence pair and list all 54 workspace members, including
psychometric_core.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
The #49 merge left two load_union_branch_totals definitions, so the first
body was dead and the live success path had no test. Keep one helper and
cover valid multi-file True/False unions.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

The #48 merge listed location_membership, validation_core, and tepp_api
twice. Keep one row each and retain terminal-result wording on tepp_api.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
@seonghobae

Copy link
Copy Markdown
Contributor Author

Superseded by the canonical ready vehicle #224 (fix/main-red-readme-fence-dedupe, base main), which contains every repair in this PR with concrete evidence on its head: (1) README.md fence balance restored (balanced ``` fence pairs vs current main's odd count from the #48 merge fallout); (2) ARCHITECTURE.md duplicate foundation-crate rows collapsed to one row each for location_membership / validation_core / tepp_api with terminal-result wording retained; (3) scripts/check_coverage.py shadowed duplicate load_union_branch_totals removed (single definition at line 40 vs current main's definitions at lines 40+152). #224 additionally repairs post-consolidation crate-source fallout beyond this PR's scope and is mergeable against main. Closing this draft as duplicated by #224 to avoid two fix vehicles racing on identical regions of README.md/ARCHITECTURE.md/check_coverage.py.

@seonghobae seonghobae closed this Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants