fix(docs): restore README fence and unique-fold helper after #48 merge - #222
fix(docs): restore README fence and unique-fold helper after #48 merge#222seonghobae wants to merge 3 commits into
Conversation
The #49 merge left two load_union_branch_totals definitions, so the first body was dead and the live success path had no test. Keep one helper and cover valid multi-file True/False unions. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The #48 merge listed location_membership, validation_core, and tepp_api twice. Keep one row each and retain terminal-result wording on tepp_api. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
|
Superseded by the canonical ready vehicle #224 (fix/main-red-readme-fence-dedupe, base main), which contains every repair in this PR with concrete evidence on its head: (1) README.md fence balance restored (balanced ``` fence pairs vs current main's odd count from the #48 merge fallout); (2) ARCHITECTURE.md duplicate foundation-crate rows collapsed to one row each for location_membership / validation_core / tepp_api with terminal-result wording retained; (3) scripts/check_coverage.py shadowed duplicate load_union_branch_totals removed (single definition at line 40 vs current main's definitions at lines 40+152). #224 additionally repairs post-consolidation crate-source fallout beyond this PR's scope and is mergeable against main. Closing this draft as duplicated by #224 to avoid two fix vehicles racing on identical regions of README.md/ARCHITECTURE.md/check_coverage.py. |
Summary
#48 merged
04f05ea4before post-merge repairs landed. Protectedmaincurrently fails docs/coverage and has a duplicated architecture table.This draft carries only those repairs:
topic_measurement,analysis_engine, andpsychometric_core.load_union_branch_totalsplus a test that unions True/False counts across instrumented copies.location_membership, onevalidation_core, and onetepp_apirow in the architecture foundation table, keeping terminal-result wording on the API row.Does not change estimator contracts, lexical-weight labels, membership-fold overflow behavior, or ADR numbering.
Test plan
python3 scripts/check_workspace_contract.pypython3 scripts/check_docstrings.pypython3 scripts/validate_documentation.pypython3 -m coverage run --branch -m unittest discover -s tests/quality -p 'test_*.py'python3 -m coverage report --fail-under=100 --show-missing(1336/662)Exact-head GitHub CI still required. Independent OpenCode APPROVE remains an org gate; this PR stays draft until that path is available.