feat(method): refuse non-lexical modality as unique content - #150
Conversation
Non-lexical modality stays explicit method structure (ADR 0004 and 0012). It is not unique latent content and is not erased by a stopword list. Recovery is the computed share of modality kinds that match known truth versus collapsing every token to unique content.
|
Warning Review limit reachedNext included review available in 43 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (18)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
# Conflicts: # CHANGELOG.md # docs/validation/temporal-event-foundation.md
|
Current head |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Current-head validation update (2e9cf6c): fixed the quality contract to derive the Rust crate count from scripts/check_workspace_contract.py instead of hard-coding 10. Local evidence: 89 quality tests passed; coverage 100% (991/991 statements, 442/442 branches); workspace, docstring, documentation, and diff checks passed. Please review and rerun Checks against this exact head; merge remains subject to the repository's two independent approvals and protected rules. |
|
Current-head review fix (00deb56): removed the duplicate active-PR Purpose-bound provider payloads ledger row; one implemented-main row now remains. Local validation passed: 89 quality tests, 100% statement/branch coverage (991/991, 442/442), workspace/docstring/documentation contracts, and diff check. Please re-review this exact head. |
|
Review the exact current PR head 00deb56 against base main with the protected independent agents. Re-check current source, tests, coverage, documentation, and security; do not modify or merge. @opencode-agent @cwl-noema-review |
|
Current-head review refresh for 00deb56:
|
|
Rebased current head f9110e0 onto origin/main. The changelog conflict retains both feature and current-main entries; inherited documentation trailing whitespace was removed. Local merge-tree, git diff --cached --check, and cargo fmt --all -- --check pass. Exact-head hosted checks and required independent approvals remain required before protected merge. |
|
@opencode-agent @cwl-noema-review Review-only request for exact current head f9110e0. Re-review modality identity and current validation ledger, the Rust identity contract, APA 7 research scope, documentation maturity, and protected-merge requirements. Do not merge or enable auto-merge. |
|
Current-head review request: exact head |
Exact-head queue dispositionExact head |
# Conflicts: # ARCHITECTURE.md # CHANGELOG.md # Cargo.lock # Cargo.toml # README.md # docs/TRACEABILITY.md # docs/adr/0004-shared-multilingual-latent-space.md # docs/adr/0012-temporal-relational-shared-latent-topic-measurement.md # docs/adr/README.md # docs/research/standards-and-literature.md # docs/validation/temporal-event-foundation.md # scripts/check_workspace_contract.py # tests/quality/test_check_docstrings.py
There was a problem hiding this comment.
📝 Info: Historical changelog line still says 'ten' crates
CHANGELOG.md still reads "Rust 1.97.1 virtual Cargo workspace with ten explicit modular foundation crates." while README.md was updated to "eleven". This CHANGELOG line is a historical Task-1 Added entry describing the original ten-crate foundation, so leaving it unchanged is arguably faithful to what was originally added rather than a defect. No test or contract script asserts a crate count against this text, so it does not break CI. Flagging only for editorial consistency consideration.
(Refers to this code)
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
📝 Info: New crate satisfies workspace contract checks
The new modality_source crate meets every requirement enforced by check_workspace_contract.py: Cargo.toml sets publish = false, [lints] workspace = true, and inherits all required package fields; lib.rs has crate-level //! rustdoc, #![forbid(unsafe_code)], and #![deny(missing_docs)] with no placeholder API; and crate_contract.rs provides the required package-identity contract test. EXPECTED_CRATES and both members/default-members lists were updated consistently, and README's crate count was updated from ten to eleven.
Was this helpful? React with 👍 or 👎 to provide feedback.
| let mut matches = 0_u32; | ||
| for (truth_kind, decided_kind) in truth.iter().zip(decided) { | ||
| if truth_kind == decided_kind { | ||
| matches += 1; | ||
| } | ||
| } | ||
| Ok(f64::from(matches) / truth.len() as f64) |
There was a problem hiding this comment.
📝 Info: Branch coverage relies on integration tests, not unit tests alone
The 100% branch-coverage contract (AGENTS.md #8) requires both branches of if truth_kind == decided_kind in kind.rs to be exercised. The in-module unit test only ever passes matching pairs, so the mismatch (false) branch is only covered by the integration test recovered_kinds_match_known_truth_better_than_a_unique_content_collapse in modality_source_contract.rs, which supplies collapsed values. Coverage therefore depends on cargo llvm-cov including integration test targets; if the coverage run scopes to lib-only, this branch would appear uncovered. Not a bug given the standard workspace coverage config, but worth noting the dependency.
Was this helpful? React with 👍 or 👎 to provide feedback.
| pub fn identity_recovery_rate( | ||
| truth: &[ModalityKind], | ||
| decided: &[ModalityKind], | ||
| ) -> Result<f64, ModalitySourceError> { | ||
| if truth.is_empty() || truth.len() != decided.len() { | ||
| return Err(ModalitySourceError::InvalidModalityPayload); | ||
| } | ||
| let mut matches = 0_u32; | ||
| for (truth_kind, decided_kind) in truth.iter().zip(decided) { | ||
| if truth_kind == decided_kind { | ||
| matches += 1; | ||
| } | ||
| } | ||
| Ok(f64::from(matches) / truth.len() as f64) | ||
| } |
There was a problem hiding this comment.
📝 Info: identity_recovery_rate fail-closed and arithmetic verified
identity_recovery_rate at kind.rs correctly fails closed for empty or length-mismatched slices before any division, and the match count divided by truth.len() cannot divide by zero due to the earlier empty check. The #![allow(clippy::cast_precision_loss)] in lib.rs is what permits the as f64 cast on the length. Logic is sound.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Non-lexical modality stays explicit method structure (ADR 0004/0012). It is not unique latent content and is not erased by a stopword list. Recovery is the computed share of recovered kinds that match known truth versus collapsing every token to unique content.
Complementary to #147 section, #148 style, #149 copied-text, #145 stopword, and #75 method_effects. This crate owns modality-versus-unique-content identity.
Local gates:
Does not allocate migration `0008`. Does not recreate those in-flight method-source crates.
Keep this PR draft. Preferred merge remains #47 only when exact-head required Checks pass and a qualifying independent APPROVE exists. Restored #144 to draft. Do not empty-commit #47.