fix(frontend): remember OIDC return URL and drop unreachable AdminPanel render on main - #573
Closed
seonghobae wants to merge 4 commits into
Closed
fix(frontend): remember OIDC return URL and drop unreachable AdminPanel render on main#573seonghobae wants to merge 4 commits into
seonghobae wants to merge 4 commits into
Conversation
…el render main's login screen builds returnUrl via raw string concatenation instead of returnUrlFromLocation()/rememberOidcReturnUrl(), leaving both imports unused (TS6192) and rendering an AdminPanel with accessToken: string | undefined on the unauthenticated branch (TS2322) -- pnpm run build fails on main's current tip. This is the same bug pattern fixed independently across several feature branches this session; landing it on main directly stops every branch built from main's tip from inheriting the broken build.
Central .github main landed 0c6b9a64 (openai-direct fallback prefix mapping + OpenAI fallback key routing), so NVIDIA NIM 429s now degrade to a working terminal OpenAI fallback instead of failing every PR's required strix check. Re-run to pick up the fixed org workflow.
Main evolved the same test to assert both session and localStorage fallbacks via the exported OIDC_RETURN_URL_STORAGE_KEY; adopt that richer form. App.tsx merged clean (main already uses returnUrlFromLocation + rememberOidcReturnUrl and dropped the unreachable AdminPanel render, matching this branch's fix).
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
seonghobae
enabled auto-merge (squash)
August 24, 2026 08:05
Contributor
Author
auto-merge was automatically disabled
August 24, 2026 08:26
Pull request was closed
Contributor
|
자동 정리: base 대비 실제 변경(diff)이 0건이라 이 PR을 닫습니다. 변경을 추가한 뒤 reopen하세요. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopen of #551 (head-sync corruption on GitHub's side). Branch now includes a merge of current main.
Fix
returnUrlFromLocation()and persists it withrememberOidcReturnUrl()(ADR 0109) so the OIDC state round-trip can't lose it.AdminPanelrender inside the unauthenticated branch (also fixes main's TS2322: accessToken was string|undefined).Unblocks every open PR whose 'Frontend lint, test, build' failure is inherited from main.