test(frontend): add Storybook coverage for WorkspaceNav - #438
Merged
seonghobae merged 4 commits intoAug 23, 2026
Merged
Conversation
BuyerNav had a test file but no story, the last remaining gap in frontend/src/components/*.tsx test+story coverage. Adds stories for each destination plus an edge case with an extra tools slot.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Same shared-ancestor bug as #418/#415/#426/#427/#429/#431/#434/#435/#436/#437: the login button built an unsanitized returnUrl inline instead of returnUrlFromLocation()/rememberOidcReturnUrl(), and removed the unreachable login-screen AdminPanel render (accessToken is always undefined pre-auth). This PR's own diff doesn't touch AdminPanel.
seonghobae
enabled auto-merge (squash)
August 22, 2026 12:52
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
seonghobae
commented
Aug 22, 2026
8 tasks
seonghobae
enabled auto-merge (squash)
August 23, 2026 06:41
seonghobae
changed the title
seonghobae
changed the base branch from
main
to
chore/rename-buyer-terminology-v2
August 23, 2026 08:27
seonghobae
merged commit Aug 23, 2026
025bb3d
into
chore/rename-buyer-terminology-v2
30 checks passed
seonghobae
added a commit
that referenced
this pull request
Aug 23, 2026
* test(frontend): cover LineageDag with tests and stories LineageDag renders the git-branch-style multi-thread lineage graph used by both the post-detail popup and the Ask Agent's multi-lineage answer view (ADR 0120), and had zero test or story coverage despite being a core, non-trivial component. Adds tests for the empty state, multi-group branch rendering, group-heading fallback for missing/UUID groups, click and keyboard node selection, the current-post marker, and label truncation with an accessible full-label fallback. Adds stories for empty, single-branch, multi-branch (with an actual fork), ungrouped, and long-label scenarios. * fix(frontend): use OIDC return-url helpers on the login button Same shared-ancestor bug as #418/#415/#426/#427/#429/#431/#434/#435/#436/#437/#438: the login button built an unsanitized returnUrl inline instead of returnUrlFromLocation()/rememberOidcReturnUrl(), and removed the unreachable login-screen AdminPanel render. * Revert "fix(frontend): use OIDC return-url helpers on the login button" This reverts commit 590c6c3. * fix(frontend): keep lineage edge evidence visible-only * fix(frontend): terminate rooted lineage cycles * chore(frontend): keep shared OIDC repair on #426 * refactor(frontend): remove unreachable cycle guard * test(frontend): cover converging lineage DAGs * fix(frontend): position converging DAG nodes once
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BuyerNav.tsxhadBuyerNav.test.tsxbut no.stories.tsx— the last remaining component-vs-story-vs-test coverage gap infrontend/src/components/(all others already have both, most recentlyAdminPanelin fix(admin): prevent no-op tenant saves and cover settings states #436 andFiveW1Hin test(frontend): cover FiveW1H with realistic tests and Storybook #437).BuyerNav.stories.tsx: Board, AskAgent, Admin destination states, plus aWithToolsedge case (an extra control rendered in the nav's tools slot, e.g. sign-out).Test plan
pnpm --dir frontend run test— 140/140 pass (13 files)pnpm --dir frontend run lint— clean except the 2 known pre-existingApp.tsxwarnings (unrelated, already fixed on fix: repair frontend build and publish ontology Pages #426)pnpm --dir frontend run build— same 2 known pre-existingApp.tsxerrors, confirmed present on pristineorigin/maintoo🤖 Generated with Claude Code