Skip to content

fix(ci): accept current direct-openai Strix fallback #1329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 2 commits into from
Closed

fix(ci): accept current direct-openai Strix fallback #1329

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
052d42e
fix(ci): accept current direct-openai Strix fallback
seonghobae Aug 25, 2026
7e80b0a
refactor(ci): make Strix fallback assertion helper explicit
seonghobae Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions scripts/ci/strix_required_workflow_smoke.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,16 +46,19 @@ assert_file_not_contains() {
fi
}

assert_file_contains_either() {
assert_file_contains_any() {
local file_path="$1"
local first_needle="$2"
local second_needle="$3"
local message="$4"
shift
local message="${!#}"
local needle_count=$(($# - 1))

if ! grep -Fq -- "$first_needle" "$file_path" &&
! grep -Fq -- "$second_needle" "$file_path"; then
record_failure "$message (missing either '$first_needle' or '$second_needle')"
fi
for needle in "${@:1:needle_count}"; do
if grep -Fq -- "$needle" "$file_path"; then
return
fi
done

record_failure "$message (missing all accepted fallback contracts)"
}
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.

assert_status_permissions_scoped() {
Expand Down Expand Up @@ -168,10 +171,12 @@ assert_file_contains "$gate_script" "NPM_CONFIG_IGNORE_SCRIPTS" "Strix gate disa
assert_file_contains "$full_gate_test" "assert_strix_workflow_pr_trigger_hardened" "Full Strix harness remains available outside the required path"

assert_file_contains "$workflow_file" "nvidia_nim/nvidia/nemotron-3-super-120b-a12b" "Strix defaults public scans to the current hosted NVIDIA NIM model"
assert_file_contains_either \
assert_file_contains_any \
"$workflow_file" \
"nvidia_nim/nvidia/llama-3.3-nemotron-super-49b-v1.5 openai_direct/gpt-5.4" \
"nvidia_nim/nvidia/llama-3.3-nemotron-super-49b-v1.5 openai-direct/gpt-5.4" \
"nvidia_nim/nvidia/llama-3.3-nemotron-super-49b-v1.5 openai_direct/gpt-5.6-luna" \
"nvidia_nim/nvidia/llama-3.3-nemotron-super-49b-v1.5 openai-direct/gpt-5.6-luna" \
"Strix tries another NVIDIA hosted model before falling back to direct OpenAI"
assert_file_not_contains "$workflow_file" "github_models/openai/o3" "Strix fallback list must not depend on GitHub Models, which is in platform-wide retirement"
assert_file_contains "$workflow_file" "Nvidia_nimException" "Strix workflow recognizes provider-scoped NVIDIA NIM failures"
Expand Down
Loading