fix(strix): align fallback model contract - #1316
Conversation
|
Warning Review limit reachedNext included review available in 12 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Follow-up on exact head |
|
Revalidated 2026-08-25T01:36Z on exact head Local worktree:
This PR does not land the banner sanitizer ( Operator land order: this needle alignment and #1311 (banner) onto |
|
Hosted required Strix on this exact head is not the banner path. This comment is not OpenCode approval and not merge evidence. Run That is a trusted-base catch-22: this PR updates the smoke on the head, but required Strix executes the smoke from Contrast, same hour: #1311 same-head re-run This PR cannot green its own required Strix until the trusted smoke on |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Exact-head update: |
|
Follow-up 01:43Z, not merge evidence. #1318 merged to This head This PR is |
|
Exact-head update: e4f9865 is based on main 8fd471a (#1318). The temporary legacy smoke marker was removed; the remaining diff is the OpenCode direct-model pool/contract alignment plus its durable evidence. This head is not related to the independent full-self-test baseline issue #571. Hosted checks restarted for this exact head; no merge is being claimed while they and qualifying reviews are incomplete. |
|
Post-#1318 required Strix on exact head
Do not fold a 502-retryable classifier into #1314. |
|
The current Strix failure on exact head e4f9865 was provider infrastructure, not a finding: NVIDIA NIM returned HTTP 429 then 502 before the configured gpt-5.4 fallback could produce a structured report. The required smoke and focused local contracts pass; I requested a direct rerun of the current Strix run. No merge readiness is inferred while the PR has no qualifying approval and other required checks are pending. |
|
Exact-current-head review request for Fresh evidence on this unchanged head:
Please generate a substantive formal Reviews API verdict bound to this exact current head. A green check/status or predecessor review is not approval and must not be counted as merge authorization. |
|
Re-run
A serialized 0-finding 49b scan would have been merge evidence if #1311 were the trusted gate. Do not fold #1311/#1295/#1297 into #1314. |
|
Superseded by #1320 exact head |
Pull request was closed
github-project-automation
Bot
moved this from In Progress
to Done
in naruon Platform Roadmap
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current heade4f9865a1b06978324f006ee3861b84953877d8b. -
Head SHA:
e4f9865a1b06978324f006ee3861b84953877d8b -
Workflow run: 32807088568
-
Workflow attempt: 1
Coverage evidence
Coverage evidence job did not run or did not publish coverage evidence.
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow: opencode-review-dispatch.yml"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow: opencode-review-dispatch.yml"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["Changed file: CHANGELOG.md"]
S2 --> I2["repository behavior"]
I2 --> R2["Review risk: Changed file: CHANGELOG.md"]
R2 --> V2["required checks"]
Evidence --> S3["Docs (3 files)"]
S3 --> I3["operator or user guidance"]
I3 --> R3["Review risk: Docs (3 files)"]
R3 --> V3["docs review"]
Evidence --> S4["CI script: emit_opencode_failed_check_fallback_findings.sh"]
S4 --> I4["review and security gate shell path"]
I4 --> R4["Review risk: CI script: emit_opencode_failed_check_fallback_findings.sh"]
R4 --> V4["bash -n plus Strix self-test"]
Evidence --> S5["Test (4 files)"]
S5 --> I5["regression suite"]
I5 --> R5["Review risk: Test (4 files)"]
R5 --> V5["targeted test run"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage evidence job did not run or did not publish coverage evidence. Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow: opencode-review-dispatch.yml"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow: opencode-review-dispatch.yml"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["Changed file: CHANGELOG.md"]
S2 --> I2["repository behavior"]
I2 --> R2["Review risk: Changed file: CHANGELOG.md"]
R2 --> V2["required checks"]
Evidence --> S3["Docs (3 files)"]
S3 --> I3["operator or user guidance"]
I3 --> R3["Review risk: Docs (3 files)"]
R3 --> V3["docs review"]
Evidence --> S4["CI script: emit_opencode_failed_check_fallback_findings.sh"]
S4 --> I4["review and security gate shell path"]
I4 --> R4["Review risk: CI script: emit_opencode_failed_check_fallback_findings.sh"]
R4 --> V4["bash -n plus Strix self-test"]
Evidence --> S5["Test (4 files)"]
S5 --> I5["regression suite"]
I5 --> R5["Review risk: Test (4 files)"]
R5 --> V5["targeted test run"]
|
Merging 8fd471a brought #1318's global luna-to-gpt-5.4 replace in test_strix_quick_gate.sh. Three OpenCode dispatch-pool assertions now expected openai/gpt-5.4, but opencode-review-dispatch.yml still lists openai/gpt-5.6-luna. Restore those needles so the harness matches the unchanged dispatch workflow. Keep the Strix quota fixtures on gpt-5.4. Do not fold the dispatch-pool model change from #1316. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
1 participant
Scope after #1318
The required-path smoke mismatch is now on main via #1318. This PR retains the remaining repair: align the privileged OpenCode direct model pool, fallback-finding diagnostics, focused contracts, and durable evidence with the executable gpt-5.4 fallback.
Change
Closes #1317
Verification