fix(strix): unblock trusted smoke during provider-prefix migration - #1286
fix(strix): unblock trusted smoke during provider-prefix migration#1286seonghobae wants to merge 3 commits into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
RCA for failed Strix job 97304258487: the trusted smoke passed. The required scan then failed closed because NVIDIA NIM returned HTTP 429, and the fallback configured on protected main used the pre-migration openai-direct alias. This is provider/control-plane evidence, not a failure of this one-file smoke compatibility change. A normal failed-job rerun is queued; merge remains blocked until a current exact-head Strix result succeeds. |
|
Exact head 677df5b against main@0c6b9a6459c9dbdf5e23fb01df7a32a8a14964b3 is unchanged. The one-file change is bounded to the protected Strix smoke compatibility assertion and preserves the canonical workflow contract; current hosted checks are queued with no failed conclusion. Please publish a substantive formal review for this exact head; no merge until all required checks and independent approval are current. |
|
@opencode-agent review Review exact current head 677df5b against protected main@0c6b9a6459c9dbdf5e23fb01df7a32a8a14964b3. Walk through the one-file smoke compatibility change and its permission/assertion boundary, then publish a substantive Reviews API verdict on this exact SHA. |
|
Exact-head RCA for 677df5b: Strix failed in run 32691523377 because NVIDIA NIM returned HTTP 429 Too Many Requests, then the configured direct fallback returned HTTP 404. The log also states no vulnerability report artifact was produced and fails closed on provider infrastructure output. This is provider/backend infrastructure evidence, not a source finding in this PR; rerun the failed Strix job under the existing gate. |
Purpose
The protected-main trusted Strix smoke test hard-codes the retired
openai-direct/alias. A PR that updates the workflow and its smoke assertion together cannot pass its ownpull_request_targetself-test because the smoke executable is intentionally loaded from protected main.Change
Accept the current canonical
openai_direct/form and the pre-migration form during this bounded transition. This preserves the trusted gate while allowing the canonical workflow PR (#1263) to pass after this prerequisite merges; #1263 still enforces the canonical form and rejects the retired alias in its own workflow contract.Verification
bash -n scripts/ci/strix_required_workflow_smoke.shbash scripts/ci/strix_required_workflow_smoke.shgit diff --checkThis is a normal protected PR prerequisite. No ruleset, required check, approval, or test policy is changed.