Skip to content

fix(strix): unblock trusted smoke during provider-prefix migration - #1286

Open
seonghobae wants to merge 3 commits into
mainfrom
fix/strix-smoke-provider-prefix-compat
Open

fix(strix): unblock trusted smoke during provider-prefix migration#1286
seonghobae wants to merge 3 commits into
mainfrom
fix/strix-smoke-provider-prefix-compat

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Purpose

The protected-main trusted Strix smoke test hard-codes the retired openai-direct/ alias. A PR that updates the workflow and its smoke assertion together cannot pass its own pull_request_target self-test because the smoke executable is intentionally loaded from protected main.

Change

Accept the current canonical openai_direct/ form and the pre-migration form during this bounded transition. This preserves the trusted gate while allowing the canonical workflow PR (#1263) to pass after this prerequisite merges; #1263 still enforces the canonical form and rejects the retired alias in its own workflow contract.

Verification

  • bash -n scripts/ci/strix_required_workflow_smoke.sh
  • bash scripts/ci/strix_required_workflow_smoke.sh
  • git diff --check

This is a normal protected PR prerequisite. No ruleset, required check, approval, or test policy is changed.


Open in Devin Review

@seonghobae seonghobae added priority: critical Immediate blocker, P0, urgent deadlock, or critical incident merge: urgent-review Central or critical pull request requiring immediate review attention area: ci-cd CI, GitHub Actions, checks, release, or supply chain type: bug Defect or incorrect behavior labels Aug 24, 2026
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4063a189-0f31-4d6d-9414-6668f0ca0e15


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@seonghobae

Copy link
Copy Markdown
Contributor Author

RCA for failed Strix job 97304258487: the trusted smoke passed. The required scan then failed closed because NVIDIA NIM returned HTTP 429, and the fallback configured on protected main used the pre-migration openai-direct alias. This is provider/control-plane evidence, not a failure of this one-file smoke compatibility change. A normal failed-job rerun is queued; merge remains blocked until a current exact-head Strix result succeeds.

@seonghobae
seonghobae enabled auto-merge (squash) August 24, 2026 03:06
@seonghobae

Copy link
Copy Markdown
Contributor Author

Exact head 677df5b against main@0c6b9a6459c9dbdf5e23fb01df7a32a8a14964b3 is unchanged. The one-file change is bounded to the protected Strix smoke compatibility assertion and preserves the canonical workflow contract; current hosted checks are queued with no failed conclusion. Please publish a substantive formal review for this exact head; no merge until all required checks and independent approval are current.

@seonghobae

Copy link
Copy Markdown
Contributor Author

@opencode-agent review

Review exact current head 677df5b against protected main@0c6b9a6459c9dbdf5e23fb01df7a32a8a14964b3. Walk through the one-file smoke compatibility change and its permission/assertion boundary, then publish a substantive Reviews API verdict on this exact SHA.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Exact-head RCA for 677df5b: Strix failed in run 32691523377 because NVIDIA NIM returned HTTP 429 Too Many Requests, then the configured direct fallback returned HTTP 404. The log also states no vulnerability report artifact was produced and fails closed on provider infrastructure output. This is provider/backend infrastructure evidence, not a source finding in this PR; rerun the failed Strix job under the existing gate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ci-cd CI, GitHub Actions, checks, release, or supply chain merge: urgent-review Central or critical pull request requiring immediate review attention priority: critical Immediate blocker, P0, urgent deadlock, or critical incident type: bug Defect or incorrect behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant