security(deploy-pages): enforce explicit caller contract - #1272
Open
seonghobae wants to merge 5 commits into
Open
security(deploy-pages): enforce explicit caller contract#1272seonghobae wants to merge 5 commits into
seonghobae wants to merge 5 commits into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
enabled auto-merge (squash)
August 24, 2026 04:07
seonghobae
enabled auto-merge (squash)
August 24, 2026 11:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The reusable Cloudflare Pages workflow predated the current least-privilege boundary: it declared no named secret interface, instructed callers to use
secrets: inherit, and interpolated caller-controlled project, path, and domain strings into Wrangler, Cloudflare URLs, and the shell summary before validation.The historical #901 implementation was source-valid but DIRTY, duplicated an unrelated CHANGELOG entry, omitted the root README from its contract test, and accepted uppercase or 59-character project names that Cloudflare Pages rejects.
Change
CLOUDFLARE_API_TOKENandCLOUDFLARE_ACCOUNT_IDatworkflow_callcontents: read, caller-repository checkout, and Cloudflare deployment semanticsConsumer evidence
A live
gh search code deploy-pages.yml@ --owner ContextualWisdomLabon 2026-08-24 returned only this central workflow plus the central root and infrastructure README examples. No product caller migration is currently required.Verification
secrets: inheritexampleUppercaseand 59-character project namesuv run --with pip coverage run -m pytest -q: 1,425 passed, 1 skipped, 16 subtestsThe explicit
--with pipisolates the current-main fresh-uv bootstrap gap tracked separately by #1265.Supersedes #901.
Closes #900.