fix(scheduler): retry OpenCode after coverage blockers clear - #1266
fix(scheduler): retry OpenCode after coverage blockers clear#1266seonghobae wants to merge 18 commits into
Conversation
|
Warning Review limit reachedNext included review available in 48 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Implemented in 9cc3aca. The same-head coverage retry-floor branch now disables an existing auto-merge request before returning the wait decision. Added a regression test covering an auto-merge-enabled current-head coverage-only review; the scheduler now remains fail-closed until the retry floor elapses without leaving auto-merge active. Verification: 1408 passed, 1 skipped, 16 subtests; compileall; git diff --check. |
|
Exact-head check RCA: Strix run 32688700442 failed closed after provider-infrastructure output, no report artifact, NVIDIA fallback failure, and direct fallback LLM Provider NOT provided. No source vulnerability evidence is present; revalidate after the provider/failover root is healthy. |
|
Exact-head update: 2a30943 Fixed the valid coverage-retry finding. The same-head retry floor now uses the later of the exact-head coverage review submission and the latest completed exact-head OpenCode repository-dispatch start. If dispatch history cannot be read, the scheduler waits fail-closed. This prevents repeated dispatch when a review run completes without publishing a new review. The central-deployment progress observation is retained as an intentional optimization boundary: CheckRun placeholders are non-authoritative, while dispatch_opencode_review remains the authoritative same-head active-run deduplicator. Local verification on this exact head: 1415 passed, 1 skipped, 16 subtests; statement and branch coverage 100%; public scheduler docstrings 100%; ruff check, compileall, and git diff check passed. Please re-review this exact head and publish substantive exact-head verdict evidence. |
|
@opencode-agent review exact head 2a30943. Read the complete changed-file diff, verify the dispatch-history retry floor and central active-run boundary, then publish substantive review evidence tied to this exact head. |
Exact-head finding dispositionCurrent exact head before restack: 2a30943
These are intentional bounded trade-offs rather than source defects. I will restack this branch onto the current main and request a fresh exact-head review after the base changes. |
Restack complete: exact-head re-review requiredThe branch was updated through the normal PR path onto current main. Current exact head: 0ffad34. Current exact base: 0c6b9a6. All predecessor checks and reviews are stale after the base update. The scheduler retry-anchor fix and its regression tests are present; the two informational findings were dispositioned with their correctness and bounded-cost rationale. Please inspect the complete current diff and publish a substantive review for this exact head. No merge is requested until required checks and independent approval are current. |
Protected-main replacement for #1152. It keeps the source-backed coverage-only retry and removes the stale audit-lock and unrelated docstring churn from the conflicted predecessor.
Root cause
A current-head OpenCode review can request changes solely because
coverage-evidencewas not yet available. Once exact-head coverage and Strix evidence become successful, the scheduler still returned at the existingCHANGES_REQUESTEDgate, so the same head never received the review needed to clear that gate.The original retry also used the environment-sensitive
is_opencode_context()classifier to ignore its superseded failing OpenCode CheckRun. Under the central required-workflow deployment that classifier deliberately treats CheckRuns as non-authoritative placeholders, which made the placeholder failure self-block the retry.Change
CHANGELOG.md.Exact local evidence
885f2cd251999f21cf562cab3e2d9cc3cc3ec7379f2ab9ae2f97be49fc4ab4dbcd13123057005b97blockinstead ofreview_dispatchbefore the fix.115 passed.uv run --with pip:1394 passed, 1 skipped, 16 subtests passed.8385statements and3240branches,100%.100%acrossscripts/ci.compileallandgit diff --check: pass.No approval, protected check, or unresolved-thread requirement is bypassed. An independent exact-head verdict remains required before merge.