Release - #1364
Open
selul wants to merge 8 commits into
Open
Conversation
A published chart whose visualizer-settings meta resolves to a string crashed Visualizer_Module_Setup::getUsage() with a PHP 8 TypeError at the unchecked array_key_exists() call, aborting the whole Themeisle SDK usage collection request. Guard the settings read, harden the sibling pro-permissions meta read the same way, and drop the dangling visualizer_logger_data registration in Visualizer_Module_Admin, which points to a method that class never had and fatals the same filter once the first crash is fixed. Fixes #1359 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Copilot review follow-ups: a string where an array-valued permission is expected (e.g. permissions.edit-specific) still crashed the usage logger via count() on PHP 8 — guard it and cover the pro branch through the visualizer_is_pro filter with a stubbed Visualizer_Pro. Also clear leftover charts before the e2e usage assertions, matching the other chart-counting specs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
An object stored in permissions['permissions'] passed the array guard and then fatalled on the array offset read, aborting usage collection. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Bumps [codeinwp/themeisle-sdk](https://github.com/Codeinwp/themeisle-sdk) from 3.3.57 to 3.3.58. - [Release notes](https://github.com/Codeinwp/themeisle-sdk/releases) - [Changelog](https://github.com/Codeinwp/themeisle-sdk/blob/v3.3.58/CHANGELOG.md) - [Commits](Codeinwp/themeisle-sdk@v3.3.57...v3.3.58) --- updated-dependencies: - dependency-name: codeinwp/themeisle-sdk dependency-version: 3.3.58 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…ettings fix: keep usage logger alive when chart settings meta is not an array
Contributor
|
Make sure you've reviewed the |
Contributor
…t/codeinwp/themeisle-sdk-3.3.58 chore(deps): bump codeinwp/themeisle-sdk from 3.3.57 to 3.3.58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issues
This release will close the following issues once merged:
Public changelog