Cape Town| 26-ITP-May | Liyema Mfengwana| Sprint 2 | Data Groups - #1444
Open
LiyemaMfengwana wants to merge 21 commits into
Open
Cape Town| 26-ITP-May | Liyema Mfengwana| Sprint 2 | Data Groups#1444LiyemaMfengwana wants to merge 21 commits into
LiyemaMfengwana wants to merge 21 commits into
Conversation
LiyemaMfengwana
added
the
Needs Review
cjyuan
reviewed
Aug 20, 2026
Comment on lines
+2
to
+4
| if (Array.isArray(object)) { | ||
| return false; | ||
| } |
Contributor
There was a problem hiding this comment.
Could you make this function to also return false when the first parameter is not an object? For examples, null, undefined, 1234, "ABCD".
Comment on lines
+5
to
+9
| const counts = {}; | ||
|
|
||
| for (const item of items) { | ||
| counts[item] = (counts[item] || 0) + 1; | ||
| } |
Contributor
There was a problem hiding this comment.
Does the following function call returns the value you expect?
tally(["toString", "toString"]);
Suggestion:
- Look up an approach to create an empty object with no inherited properties, or
- use
Object.hasOwn()
cjyuan
added
Reviewed
LiyemaMfengwana
added
the
Needs Review
cjyuan
removed
Needs Review
cjyuan
added
the
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Complete work