Admin Bugbash Fixes by Yurika-Kan · Pull Request #209 · Code-4-Community/ssf

Yurika-Kan · 2026-08-12T04:17:36Z

📝 Description

Navbar clears the user only on unauthenticated, killing the load/refresh flicker; phone validation messages reworded.
Invalid ?donationId / ?orderId deep links show a "not found" error.
Donation Statistics totals fetch is independent of pagination, so "All Pantries" renders on every page.
Failed application fetches render an "Unable to Load Applications" error state.
Application Review "View Details" uses navigate() instead of href (SPA transition).
Cognito errors include the AWS reason and re-throw existing HttpExceptions.
Approve Food Manufacturers pagination arrows disable at first/last page.
Pantry assignee column checks for active volunteers before falling back to "No Volunteer".
User Management shows an "Admin" badge on admin rows.
Donation / Pantry / Manufacturer / Order Management show a "no results match filter" state.
Order Management table wrapped in overflowX="auto".
Removed dev-only "All Pages" nav link.
Donation details and delete modals hold the last donation in a ref while closing, fixing focus-trap errors.
Admin order table now refreshes auto after allocation edits.

… state

…is deactivated

…l scroll

Copilot

Pull request overview

This PR bundles a set of admin-facing UI/UX bug fixes across the frontend (empty/error states, pagination behavior, SPA navigation, table overflow, and modal stability) plus backend improvements to validation messages and Cognito error propagation, along with an auth endpoint audit document.

Changes:

Improve admin list pages: add “no matching results” / error states, fix pagination behaviors, and enhance navigation/labels.
Stabilize donation modals during close (avoid focus-trap/body-lock issues) and refresh admin orders after allocation edits.
Update backend phone validation messages and include underlying Cognito/AWS failure reasons in auth errors; add backend auth posture audit doc.

Reviewed changes

Copilot reviewed 19 out of 21 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
apps/frontend/src/containers/userManagement.tsx	Adds an “Admin” badge for admin rows in the volunteer table.
apps/frontend/src/containers/approvePantries.tsx	Adds fetch error state UI and switches “View Details” to SPA navigation.
apps/frontend/src/containers/approveFoodManufacturers.tsx	Adds fetch error UI, “no matching applications” empty state, SPA navigation, and disables pagination arrows at bounds.
apps/frontend/src/containers/adminPantryManagement.tsx	Adds “no pantries / no matching pantries” empty state and refines assignee display to only consider active volunteers.
apps/frontend/src/containers/adminOrderManagement.tsx	Refactors order fetch into a reusable callback, adds deep-link “not found” error, refreshes after edits, and adds horizontal overflow for the table.
apps/frontend/src/containers/adminDonationStats.tsx	Fetches total stats independent of pagination so “All Pantries” totals render on every page.
apps/frontend/src/containers/adminDonation.tsx	Adds deep-link “donation not found” error, adds filtered empty state, and renders details modal in a way that supports stable closing.
apps/frontend/src/components/Navbar.tsx	Avoids clearing current user during non-unauthenticated transitions; removes dev-only nav link; adjusts label text.
apps/frontend/src/components/forms/fmDeleteDonationModal.tsx	Holds the last donation in a ref during close to prevent modal lock/focus issues.
apps/frontend/src/components/forms/donationDetailsModal.tsx	Holds the last donation in a ref during close; updates header/details rendering accordingly.
apps/backend/src/users/dtos/userSchema.dto.ts	Updates phone validation message wording.
apps/backend/src/users/dtos/update-user-info.dto.ts	Updates phone validation message wording.
apps/backend/src/pantries/dtos/update-pantry-application.dto.ts	Updates secondary contact phone validation message wording.
apps/backend/src/pantries/dtos/pantry-application.dto.ts	Updates phone and secondary contact phone validation message wording.
apps/backend/src/foodManufacturers/dtos/update-manufacturer-application.dto.ts	Updates secondary contact phone validation message wording.
apps/backend/src/foodManufacturers/dtos/manufacturer-application.dto.ts	Updates phone and secondary contact phone validation message wording.
apps/backend/src/auth/dtos/sign-up.dto.ts	Updates phone validation message wording.
apps/backend/src/auth/auth.service.ts	Re-throws existing `HttpException`s and appends underlying error “reason” to internal server errors.
apps/backend/src/auth/AUTH_AUDIT.md	Adds a living inventory of backend routes and their auth/guard posture.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

+  if (donation) donationRef.current = donation;
+  const displayDonation = donation ?? donationRef.current;
+
  const donationId = donation?.donationId;


                    <Link
                      color="neutral.700"
                      fontWeight={400}
                      textStyle="p2"
                      variant="underline"


+                      <Link
+                        color="neutral.700"
+                        fontWeight={400}
+                        textStyle="p2"
+                        variant="underline"
+                        textDecorationColor="neutral.700"
+                        onClick={() =>
+                          navigate(
+                            ROUTES.FOOD_MANUFACTURER_APPLICATION_DETAILS.replace(
+                              ':applicationId',
+                              String(foodManufacturer.foodManufacturerId),
+                            ),
+                          )
+                        }
+                      >


dburkhart07 · 2026-08-12T07:08:28Z

+                          );
+                        })()
+                      ) : (
+                        <Box color="neutral.600" fontStyle="p2">


this is also a valid comment.

  @IsPhoneNumber('US', {
    message:
-      'Secondary contact phone must be a valid phone number (make sure all the digits are correct)',
+      'Secondary phone contact must be a valid phone number. Make sure all the digits are correct.',
  })


dburkhart07 · 2026-08-12T06:50:12Z

  @IsPhoneNumber('US', {
    message:
-      'secondaryContactPhone must be a valid phone number (make sure all the digits are correct)',
+      'Secondary phone contact must be a valid phone number. Make sure all the digits are correct.',
  })


nit: this is a valid comment that we should implement

  @IsPhoneNumber('US', {
    message:
-      'secondaryContactPhone must be a valid phone number (make sure all the digits are correct)',
+      'Secondary phone contact must be a valid phone number. Make sure all the digits are correct.',
  })


  @IsPhoneNumber('US', {
    message:
-      'secondaryContactPhone must be a valid phone number (make sure all the digits are correct)',
+      'Secondary phone contact must be a valid phone number. Make sure all the digits are correct.',
  })


dburkhart07

one other thing: is the test.ico actually needed here?

dburkhart07 · 2026-08-12T06:43:50Z

@@ -0,0 +1,195 @@
+# Backend Auth Audit


Is this file meant to be here?

dburkhart07 · 2026-08-12T06:45:18Z

  @IsPhoneNumber('US', {
    message:
-      'phone must be a valid phone number (make sure all the digits are correct)',
+      'Phone must be a valid phone number. Make sure all the digits are correct.',


For consistency and to avoid confusion, I think we should make all of these "Phone must be a valid US phone number"

dburkhart07 · 2026-08-12T06:50:12Z

  @IsPhoneNumber('US', {
    message:
-      'secondaryContactPhone must be a valid phone number (make sure all the digits are correct)',
+      'Secondary phone contact must be a valid phone number. Make sure all the digits are correct.',
  })


nit: this is a valid comment that we should implement

dburkhart07 · 2026-08-12T06:55:19Z

      </RouterLink>

      <VStack align="stretch" gap={2} flex={1} overflowY="auto">
-        <NavLink


While we are at it, we should delete the HOME route here I think

dburkhart07 · 2026-08-12T07:05:12Z

+    }
  }, [setAlertMessage]);

+  useEffect(() => {


Was this a dependency issue and thats why it needed to be a callback? I thought we have a lot of these dependency issues throughout the code. Why are we just cleaning up this one?

dburkhart07 · 2026-08-12T07:08:28Z

+                          );
+                        })()
+                      ) : (
+                        <Box color="neutral.600" fontStyle="p2">


this is also a valid comment.

dburkhart07 · 2026-08-12T07:13:10Z

+          )}

          {totalPages > 1 && (
            <Pagination.Root


our current Pagination uses 2 different patterns it seems.

Pattern 1:

<Pagination.PrevTrigger color="neutral.800" variant="outline" disabled={currentPage === 1} _hover={{ color: 'black', cursor: 'pointer' }} > <ChevronLeft size={16} /> </Pagination.PrevTrigger>

Pattern 2:

<Pagination.PrevTrigger asChild> <IconButton variant="ghost" disabled={currentPage === 1} onClick={() => setCurrentPage((prev) => Math.max(prev - 1, 1))} > <ChevronLeft /> </IconButton> </Pagination.PrevTrigger>

We should choose just one of these (I think the second one is better), apply the same change for the Pagination next trigger, put it into a separate UI component, and then use those 2 components throughout the entire code, for consistency

dburkhart07 · 2026-08-12T07:14:39Z

                      {getInitials(volunteer.firstName, volunteer.lastName)}
                    </Box>
                    {volunteer.firstName} {volunteer.lastName}
+                    {volunteer.role === Role.ADMIN && (


only admins can access this page anyways i thought. why do we need this?

Prevents "Donation #undefined" header flash during modal close animation.

Yurika-Kan added 16 commits July 25, 2026 18:04

login UI cleaned

501e100

Homepage UI

db39afa

Merge remote-tracking branch 'origin/main' into yk/admin-bugbash

a22c5b6

UI flicker on page load/refresh

186714d

bad deep-link id fix

ddeb91c

donation stats pagination

52174c9

fix API failure on Application Review renders No Applications success…

f64cffa

… state

better user promotion aws language

bfb1d7e

fix Pagination arrows on Approve Food Manufacturers

56e7f6b

fix Pantry assignee cell renders blank when every assigned volunteer …

3e4e762

…is deactivated

User Management lists admins but has no Role label

711c863

Filtering to zero results shows a bare table or wrong copy

104ee89

Order Management table is cut off on narrow windows with no horizonta…

77538f5

…l scroll

remove all pages from navbars

7fc7298

focus trap errors

ea2efd2

Admin order table does not refresh after editing allocations

518b29a

Copilot AI lite review requested due to automatic review settings August 12, 2026 04:17

Copilot started reviewing on behalf of Yurika-Kan August 12, 2026 04:18 View session

Copilot AI reviewed Aug 12, 2026

View reviewed changes

dburkhart07 requested changes Aug 12, 2026

View reviewed changes

Yurika-Kan added 2 commits August 13, 2026 01:56

cleanup & phone number wording

d6561b2

fix: derive donationId from displayDonation, not donation

d21c358

Prevents "Donation #undefined" header flash during modal close animation.

Navigation Menu

Uh oh!

Admin Bugbash Fixes - #209

Admin Bugbash Fixes#209
Yurika-Kan wants to merge 18 commits into
mainfrom
yk/admin-bugbash

Yurika-Kan commented Aug 12, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

dburkhart07 Aug 12, 2026

Uh oh!

dburkhart07 Aug 12, 2026

Uh oh!

dburkhart07 left a comment

Uh oh!

dburkhart07 Aug 12, 2026

Uh oh!

dburkhart07 Aug 12, 2026

Uh oh!

dburkhart07 Aug 12, 2026

Uh oh!

dburkhart07 Aug 12, 2026

Uh oh!

dburkhart07 Aug 12, 2026

Uh oh!

dburkhart07 Aug 12, 2026

Uh oh!

dburkhart07 Aug 12, 2026

Uh oh!

dburkhart07 Aug 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Yurika-Kan commented Aug 12, 2026

📝 Description

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dburkhart07 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants