Fix Box::unwrap leaking the heap allocation - #10
Merged
Conversation
Copy T out then ion_box_free the box pointer without dropping T, so nested heap in the payload is not double-freed. Move-marking still skips a second free at scope exit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Box::unwrapnow copiesTout, then callsion_box_freeon the box pointer. It does not dropT, so nested heap in the payload is not double-freed.test_box_unwrap_same_scope.ion).cgenmust_matchforion_box_free(_box), plus a Linux CI leak-sanitizer step (detect_leaks=1) on unwrap tests. Existing ASan smoke stays atdetect_leaks=0.Test plan
cargo fmt,clippy -D warnings,cargo testtests/test_runner.sh(272/272)ion-buildfor all 14 examples; non-interactive examples run