chore: enhance GitHub workflows with linting step

.github/workflows/deploy-Dataspace.yml

@@ -54,6 +54,9 @@ jobs:
           BACKEND_GRAPHQL_URL: ${{ vars.BACKEND_GRAPHQL_URL }}
           NODE_ENV: production
 
+      - name: Lint
+        run: npm run lint
+
       - name: Build
         run: npm run build
 

.github/workflows/pre-merge.yml

@@ -47,5 +47,9 @@ jobs:
         run: npm run generate
         env:
           BACKEND_GRAPHQL_URL: ${{vars.BACKEND_GRAPHQL_URL}}
+
+      - name: Lint
+        run: npm run lint
+
       - name: Build application
         run: npm run build --if-present

app/[locale]/(user)/collaboratives/CollaborativesListingClient.tsx

@@ -8,7 +8,6 @@ import { useQuery } from '@tanstack/react-query';
 import { Button, Card, Icon, SearchInput, Select, Text } from 'opub-ui';
 
 import { GraphQLPublic } from '@/lib/api';
-import { getCollaborativeDetailUrl } from '@/lib/collaborativesRouting';
 import { cn, formatDate, generateJsonLd } from '@/lib/utils';
 import BreadCrumbs from '@/components/BreadCrumbs';
 import { Icons } from '@/components/icons';

app/[locale]/(user)/collaboratives/[collaborativeSlug]/page.tsx

@@ -55,7 +55,7 @@ export async function generateMetadata({
         image: `${process.env.NEXT_PUBLIC_PLATFORM_URL}/og.png`,
       },
     });
-  } catch (error) {
+  } catch {
     // Fallback to generic metadata if the API call fails
     return generatePageMetadata({
       title: `Collaborative Details | CivicDataSpace`,

app/[locale]/(user)/collaboratives/components/Details.tsx

@@ -44,7 +44,7 @@ const PrimaryDetails = ({ data, isLoading }: { data: any; isLoading: any }) => {
               <Button
                 kind="tertiary"
                 className="lg:hidden"
-                onClick={(e) => setOpen(true)}
+                onClick={() => setOpen(true)}
               >
                 <div className="flex items-center gap-2 py-2">
                   <Icon source={Icons.info} size={24} color="default" />

app/[locale]/(user)/components/ListingComponent.tsx

@@ -8,7 +8,6 @@ import { fetchData } from '@/fetch';
 import { useTourTrigger } from '@/hooks/use-tour-trigger';
 import {
   Button,
-  ButtonGroup,
   Card,
   Icon,
   Pill,
@@ -237,7 +236,7 @@ const ListingComponent: React.FC<ListingProps> = ({
   const [variables, setVariables] = useState('');
   const [open, setOpen] = useState(false);
   const [queryParams, setQueryParams] = useReducer(queryReducer, initialState);
-  const [view, setView] = useState<'collapsed' | 'expanded'>('collapsed');
+  const [view] = useState<'collapsed' | 'expanded'>('collapsed');
 
   const count = facets?.total ?? 0;
   const datasetDetails = facets?.results ?? [];

app/[locale]/(user)/datasets/[datasetIdentifier]/components/PrimaryData/index.tsx

@@ -43,7 +43,7 @@ const PrimaryData: React.FC<PrimaryDataProps> = ({ data, isLoading }) => {
                 <Button
                   kind="tertiary"
                   className="lg:hidden"
-                  onClick={(e) => setOpen(true)}
+                  onClick={() => setOpen(true)}
                 >
                   <div className="flex items-center gap-2 py-2">
                     <Icon source={Icons.info} size={24} color="default" />

app/[locale]/(user)/datasets/[datasetIdentifier]/components/SimilarDatasets/index.tsx

@@ -1,5 +1,4 @@
 import { useParams } from 'next/navigation';
-import { stripMarkdown } from '@/app/[locale]/(user)/search/components/UnifiedListingComponent';
 import { graphql } from '@/gql';
 import { useQuery } from '@tanstack/react-query';
 import {

app/[locale]/(user)/publishers/PublishersListingClient.tsx

@@ -4,7 +4,7 @@ import { useState } from 'react';
 import Image from 'next/image';
 import { graphql } from '@/gql';
 import { useQuery } from '@tanstack/react-query';
-import { Button, ButtonGroup, Spinner, Text } from 'opub-ui';
+import { Button, ButtonGroup, Text } from 'opub-ui';
 
 import { GraphQL } from '@/lib/api';
 import { cn, generateJsonLd } from '@/lib/utils';

app/[locale]/(user)/search/components/UnifiedListingComponent.tsx

@@ -1,14 +1,12 @@
 'use client';
 
-import React, { useEffect, useReducer, useRef, useState } from 'react';
+import React, { useEffect, useMemo, useReducer, useRef, useState } from 'react';
 import Link from 'next/link';
 import { useRouter } from 'next/navigation';
 import GraphqlPagination from '@/app/[locale]/dashboard/components/GraphqlPagination/graphqlPagination';
 import {
   Button,
-  ButtonGroup,
   Card,
-  Icon,
   Pill,
   SearchInput,
   Select,
@@ -315,7 +313,7 @@ const UnifiedListingComponent: React.FC<UnifiedListingProps> = ({
   const [variables, setVariables] = useState('');
   const [open, setOpen] = useState(false);
   const [queryParams, setQueryParams] = useReducer(queryReducer, initialState);
-  const [view, setView] = useState<'collapsed' | 'expanded'>('collapsed');
+  const [view] = useState<'collapsed' | 'expanded'>('collapsed');
   const [persistedTypeCounts, setPersistedTypeCounts] = useState<
     Record<string, number>
   >({});
@@ -382,10 +380,6 @@ const UnifiedListingComponent: React.FC<UnifiedListingProps> = ({
     setQueryParams({ type: 'SET_SORT', payload: sortOption });
   };
 
-  const handleOrderChange = (sortOrder: string) => {
-    setQueryParams({ type: 'SET_ORDER', payload: sortOrder });
-  };
-
   const handleTypeFilter = (types: string) => {
     setQueryParams({ type: 'SET_TYPES', payload: types });
   };
@@ -444,7 +438,10 @@ const UnifiedListingComponent: React.FC<UnifiedListingProps> = ({
     );
 
   // Get type counts from aggregations
-  const typeCounts = aggregations.types || {};
+  const typeCounts = useMemo(
+    () => aggregations.types || {},
+    [aggregations.types]
+  );
   const liveTypeCounts = Object.entries(typeCounts).reduce(
     (acc, [key, value]) => {
       if (typeof value === 'number') {
@@ -457,13 +454,23 @@ const UnifiedListingComponent: React.FC<UnifiedListingProps> = ({
   const displayTypeCounts = { ...persistedTypeCounts, ...liveTypeCounts };
 
   useEffect(() => {
-    if (Object.keys(liveTypeCounts).length === 0) return;
+    const counts = Object.entries(typeCounts).reduce(
+      (acc, [key, value]) => {
+        if (typeof value === 'number') {
+          acc[key] = value;
+        }
+        return acc;
+      },
+      {} as Record<string, number>
+    );
+
+    if (Object.keys(counts).length === 0) return;
 
     setPersistedTypeCounts((prev) => {
       const next = { ...prev };
       let changed = false;
 
-      Object.entries(liveTypeCounts).forEach(([key, value]) => {
+      Object.entries(counts).forEach(([key, value]) => {
         if (next[key] !== value) {
           next[key] = value;
           changed = true;

app/[locale]/(user)/sectors/SectorsListing.tsx

@@ -48,7 +48,7 @@ const SectorsListing = () => {
 
   useEffect(() => {
     refetch();
-  }, [searchText]);
+  }, [searchText, refetch]);
 
   const handleSortChange = (e: string) => {
     const [field, direction] = e.split('_');

app/[locale]/(user)/usecases/components/Details.tsx

@@ -42,7 +42,7 @@ const PrimaryDetails = ({ data, isLoading }: { data: any; isLoading: any }) => {
               <Button
                 kind="tertiary"
                 className="lg:hidden"
-                onClick={(e) => setOpen(true)}
+                onClick={() => setOpen(true)}
               >
                 <div className="flex items-center gap-2 py-2">
                   <Icon source={Icons.info} size={24} color="default" />

app/[locale]/dashboard/[entityType]/[entitySlug]/admin/page.tsx

@@ -176,7 +176,7 @@ const Admin = () => {
   useEffect(() => {
     usersList.refetch();
     setRefetch(false);
-  }, [refetch]);
+  }, [refetch, usersList]);
 
   return (
     <div>