Skip to content

Fix two ECS deploy workflow conditionals #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saqibmanan merged 2 commits into from
Aug 18, 2026
Merged

Fix two ECS deploy workflow conditionals #109

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ada230
fix: always run the CloudFormation deploy, don't guess from head_commit
saqibmanan Aug 17, 2026
abeb9d1
fix: stop deploy-app running on a cancelled workflow
saqibmanan Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/deploy-to-ecs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ jobs:
name: Deploy Infrastructure
runs-on: ubuntu-latest
environment: development
if: github.event_name == 'workflow_dispatch' || contains(github.event.head_commit.modified, 'aws/cloudformation')

steps:
- name: Checkout
Expand Down Expand Up @@ -62,7 +61,6 @@ jobs:
runs-on: ubuntu-latest
environment: development
needs: deploy-infrastructure
if: always() # Run even if infrastructure deployment is skipped

steps:
- name: Checkout
Expand Down