fix: rename Rust release asset to docker-socket-policy-rs-linux-amd64 - #22
Merged
Conversation
The upload step used gh release upload's #label syntax, which only sets
the GitHub UI display label but doesn't rename the actual uploaded file.
The raw asset name stayed as the binary basename 'docker-socket-policy',
inconsistent with Go ('docker-socket-policy-go') and TS
('docker-socket-policy-ts-vX.Y.Z.tar.gz').
Copy the binary to the target filename before uploading so the real asset
name is descriptive and consistent across all three languages.
Closes #18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The upload step in
release.ymlusedgh release upload's#labelsyntax, which only sets the GitHub UI display label but doesn't rename the actual uploaded file. The raw asset name stayed as the binary basenamedocker-socket-policy, inconsistent with Go (docker-socket-policy-go) and TS (docker-socket-policy-ts-vX.Y.Z.tar.gz).Fix
Copy the binary to the target filename before uploading so the real asset name is descriptive and consistent across all three languages.
Verification
Will confirm on the next release run (triggered by this PR's merge) that the Rust asset name matches
docker-socket-policy-rs-linux-amd64in the release assets list.Closes #18