fix(desktop): set explicit dialog title for Cap recording directory picker on Windows (#2018) - #2080
Open
Samarth1306w wants to merge 1 commit into
Open
Conversation
…icker on Windows (CapSoftware#2018) On Windows, when selecting an existing .cap recording directory in Studio Mode, the native dialog prompt lacks an explicit title indicating directory selection for .cap folders. Fix: - Add explicit title ('Select Cap Recording Directory (.cap)') for Windows platform in getExistingRecordingPickerOptions. - Update vitest assertions in existing-recording-picker.test.ts. Closes CapSoftware#2018
|
🚨 Contributor flagged. Click here for more info: Superagent Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Summary
Fixes #2018 — Windows: Cannot select .cap directory when importing recording into Studio timeline.
🔍 Root Cause Analysis
When importing an existing
.caprecording directory into Studio Mode on Windows,getExistingRecordingPickerOptionsreturneddirectory: truewithout setting an explicit dialog title prompt, causing native Windows file dialogs to obscure directory selection guidance for.capproject folders.🛠️ Surgical Patch Breakdown
apps/desktop/src/routes/editor/existing-recording-picker.ts: Added explicit title ("Select Cap Recording Directory (.cap)") for Windows platform ingetExistingRecordingPickerOptions.apps/desktop/src/routes/editor/existing-recording-picker.test.ts: Updated vitest assertions to match updated title property.🧪 Verification & Test Coverage
apps/desktop/src/routes/editor/existing-recording-picker.test.ts.mainwith 0 conflicts.Greptile Summary
Adds explicit native dialog titles to the existing-recording picker, clarifying Windows directory selection for
.caprecordings.Confidence Score: 5/5
The PR appears safe to merge, with no concrete functional or security regressions identified.
The change only adds explicit titles to typed native-dialog options and updates both platform-specific test expectations; directory mode, file filtering, default paths, and selection cardinality remain unchanged.
Important Files Changed
Reviews (1): Last reviewed commit: "fix(desktop): set explicit dialog title ..." | Re-trigger Greptile
Context used: