Skip to content

fix(deps): clear all npm audit advisories via overrides + update (0 vulns) - #5

Merged
CallMeTechie merged 2 commits into
masterfrom
harden/override-high-advisories
May 24, 2026
Merged

fix(deps): clear all npm audit advisories via overrides + update (0 vulns)#5
CallMeTechie merged 2 commits into
masterfrom
harden/override-high-advisories

Conversation

@CallMeTechie

@CallMeTechie CallMeTechie commented May 24, 2026

Copy link
Copy Markdown
Owner

Was

Bereinigt alle npm audit-Advisories in windows-client (Ergebnis: 0 vulnerabilities). windows-client hat nur 1 Prod-Dep (@gatecontrol/client-core via file:) — alle Findings kamen transitiv.

Paket alt → neu Mechanismus Pfad / Hinweis
axios 1.15.0 → ^1.16.1 override via client-core; HIGH (Prototype-Pollution-Auth-Bypass, SSRF, CRLF, Null-Byte)
@xmldom/xmldom 0.8.12 → 0.8.13 override electron-builder → dmg-builder → osx-sign (macOS-Pfad, bei --win nie ausgeführt)
fast-uri 3.1.0 → 3.1.2 override electron-store → conf → ajv
ip-address 10.1.0 → 10.1.1 override socks → node-gyp → @electron/rebuild (Build-Zeit; XSS in Address6-HTML, wird nie aufgerufen)
brace-expansion 5.0.5 → 5.0.6 npm update minimatch → electron-builder; DoS GHSA-jxxr-4gwj-5jf2

Impact-Prüfung

  • Gepatchte Versionen sind range-kompatibel mit den Parents → keine Breaking Changes.
  • brace-expansion brauchte keinen Override (minimatch erlaubt mit ^5.0.5 bereits 5.0.6, Lockfile war nur veraltet); 1.x/2.x-Instanzen erhielten harmlose Within-Range-Bumps.
  • npm ci bleibt hier bewusst aus (file:-Rewrite zur CI-Laufzeit, siehe client-core-Setup).
  • Nur package.json + package-lock.json geändert; file:-Link unberührt.

Der axios-Override ist belt-and-suspenders, bis client-core axios selbst auf ^1.16.1 hebt (PR #3) — danach gefahrlos entfernbar.

Add npm overrides to pin vulnerable transitive dependencies to patched
versions (no direct deps affected; all came in transitively):

- axios ^1.16.1   (was 1.15.0 via @gatecontrol/client-core) — clears
  prototype-pollution auth bypass, SSRF, CRLF, null-byte HIGH advisories
- @xmldom/xmldom 0.8.13 (was 0.8.12 via electron-builder/dmg-builder's
  macOS osx-sign path — never executed in --win builds, but cleared anyway)
- fast-uri 3.1.2  (was 3.1.0 via electron-store->conf->ajv)

npm audit: 3 HIGH -> 0 HIGH (2 moderate ip-address remain).
The axios override is belt-and-suspenders until client-core bumps axios
(separate PR); safe to drop afterwards.
- ip-address 10.1.1 override (was 10.1.0 via socks/node-gyp/@electron/rebuild;
  XSS in Address6 HTML methods — build-time only, never emits HTML)
- brace-expansion bumped 5.0.5 -> 5.0.6 via npm update (DoS GHSA-jxxr-4gwj-5jf2;
  within minimatch's existing ^5.0.5 range, no override needed; 1.x/2.x
  instances got harmless within-range patch bumps)

npm audit: 0 vulnerabilities.
@CallMeTechie CallMeTechie changed the title fix(deps): override transitive deps to clear HIGH advisories fix(deps): clear all npm audit advisories via overrides + update (0 vulns) May 24, 2026
@CallMeTechie
CallMeTechie merged commit 32f2467 into master May 24, 2026
5 checks passed
@CallMeTechie
CallMeTechie deleted the harden/override-high-advisories branch May 24, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant