Skip to content

[AutoPR azure-mgmt-storagesync]-generated-from-SDK Generation - Python-6699903 - #48577

Open
azure-sdk-automation[bot] wants to merge 2 commits into
mainfrom
sdkauto/azure-mgmt-storagesync-6699903
Open

[AutoPR azure-mgmt-storagesync]-generated-from-SDK Generation - Python-6699903#48577
azure-sdk-automation[bot] wants to merge 2 commits into
mainfrom
sdkauto/azure-mgmt-storagesync-6699903

Conversation

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

Configurations: 'specification/storagesync/resource-manager/Microsoft.StorageSync/StorageSync/tspconfig.yaml', SDK Release Type: stable, and CommitSHA: '85d7676f040b7a29c22517db77a0ac0fd6b8e496' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6699903 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=36034 Submitted by: ankushb@microsoft.com

….StorageSync/StorageSync/tspconfig.yaml', SDK Release Type: stable, and CommitSHA: '85d7676f040b7a29c22517db77a0ac0fd6b8e496' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6699903 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Copilot AI balanced review requested due to automatic review settings August 13, 2026 19:26
@azure-sdk-automation azure-sdk-automation Bot added the auto-release When merged to main, release pipelines for this PR's changed packages trigger automatically. label Aug 13, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
9 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.

Updates the azure-mgmt-storagesync SDK generation to the newer StorageSync ARM API version and adds CloudEndpoint update (PATCH) support, along with associated models, samples, and tests.

Changes:

  • Bump default API version to 2025-12-01 and update spec commit references.
  • Add CloudEndpointsOperations.begin_update (sync + async) plus new update parameter models/types.
  • Extend models/enums (e.g., CloudEndpoint change enumeration interval, sync session warning type) and regenerate samples/tests.

Reviewed changes

Copilot reviewed 69 out of 69 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
sdk/storage/azure-mgmt-storagesync/tsp-location.yaml Updates the source swagger/spec commit reference used for generation.
sdk/storage/azure-mgmt-storagesync/generated_tests/test_storage_sync_mgmt_cloud_endpoints_operations_async.py Adds async test coverage for CloudEndpoint update and updates create payload.
sdk/storage/azure-mgmt-storagesync/generated_tests/test_storage_sync_mgmt_cloud_endpoints_operations.py Adds sync test coverage for CloudEndpoint update and updates create payload.
sdk/storage/azure-mgmt-storagesync/generated_samples/workflows_list_by_storage_sync_service.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/workflows_get.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/workflows_abort.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/sync_groups_list_by_storage_sync_service.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/sync_groups_get.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/sync_groups_delete.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/sync_groups_create.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/storage_sync_services_update.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/storage_sync_services_list_by_subscription.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/storage_sync_services_list_by_resource_group.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/storage_sync_services_get.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/storage_sync_services_delete.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/storage_sync_services_create.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/storage_sync_service_check_name_availability_available.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/storage_sync_service_check_name_availability_already_exists.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/server_endpoints_update.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/server_endpoints_recall.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/server_endpoints_list_by_sync_group.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/server_endpoints_get.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/server_endpoints_delete.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/server_endpoints_create.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/registered_servers_update.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/registered_servers_trigger_rollover.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/registered_servers_list_by_storage_sync_service.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/registered_servers_get.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/registered_servers_delete.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/registered_servers_create.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/private_link_resources_list.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/private_endpoint_connections_list_by_storage_sync_service.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/private_endpoint_connections_get.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/private_endpoint_connections_delete.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/private_endpoint_connections_create.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/operations_list.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/operation_status_get.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/location_operation_status_get.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/cloud_endpoints_update.py Adds a new sample demonstrating CloudEndpoint update.
sdk/storage/azure-mgmt-storagesync/generated_samples/cloud_endpoints_trigger_change_detection.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/cloud_endpoints_restore_heatbeat.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/cloud_endpoints_pre_restore.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/cloud_endpoints_pre_backup.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/cloud_endpoints_post_restore.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/cloud_endpoints_post_backup.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/cloud_endpoints_list_by_sync_group.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/cloud_endpoints_get.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/cloud_endpoints_delete.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/cloud_endpoints_create.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/generated_samples/cloud_endpoints_afs_share_metadata_certificate_public_keys.py Updates x-ms-original-file reference to the new API version.
sdk/storage/azure-mgmt-storagesync/azure/mgmt/storagesync/types.py Adds update TypedDicts and aligns type docs with wire names; adds new property docs.
sdk/storage/azure-mgmt-storagesync/azure/mgmt/storagesync/operations/_operations.py Bumps default api-version, adds CloudEndpoint update request builder + operation.
sdk/storage/azure-mgmt-storagesync/azure/mgmt/storagesync/models/_models.py Adds update models, new properties, and expands sync activity status fields.
sdk/storage/azure-mgmt-storagesync/azure/mgmt/storagesync/models/_enums.py Adds ServerEndpointSyncSessionWarningType enum.
sdk/storage/azure-mgmt-storagesync/azure/mgmt/storagesync/models/init.py Exposes new models/enums in public package exports.
sdk/storage/azure-mgmt-storagesync/azure/mgmt/storagesync/aio/operations/_operations.py Adds async CloudEndpoint update operation and request builder import.
sdk/storage/azure-mgmt-storagesync/azure/mgmt/storagesync/aio/_configuration.py Updates default api-version and adjusts lint suppression.
sdk/storage/azure-mgmt-storagesync/azure/mgmt/storagesync/aio/_client.py Updates client docstrings and lint suppression for new API version.
sdk/storage/azure-mgmt-storagesync/azure/mgmt/storagesync/_version.py Bumps package version to 2.1.0.
sdk/storage/azure-mgmt-storagesync/azure/mgmt/storagesync/_validation.py Adds runtime API version validation decorator used by new operations.
sdk/storage/azure-mgmt-storagesync/azure/mgmt/storagesync/_utils/serialization.py Expands serializer docstring to document constructor parameters.
sdk/storage/azure-mgmt-storagesync/azure/mgmt/storagesync/_utils/model_base.py Adds bool-as-string deserialization and expands encoder docstring.
sdk/storage/azure-mgmt-storagesync/azure/mgmt/storagesync/_configuration.py Updates default api-version and adjusts lint suppression.
sdk/storage/azure-mgmt-storagesync/azure/mgmt/storagesync/_client.py Updates client docstrings and lint suppression for new API version.
sdk/storage/azure-mgmt-storagesync/apiview-properties.json Updates APIView mappings for new models/methods and cross-language hash.
sdk/storage/azure-mgmt-storagesync/api.metadata.yml Updates API MD hash and parser version metadata.
sdk/storage/azure-mgmt-storagesync/api.md Regenerates public API surface documentation to reflect new types/ops.
sdk/storage/azure-mgmt-storagesync/_metadata.json Updates generator metadata: apiVersion, commit, and http client version.
sdk/storage/azure-mgmt-storagesync/CHANGELOG.md Adds 2.1.0 release notes describing newly added API surface.
Suppressed comments (2)

sdk/storage/azure-mgmt-storagesync/generated_tests/test_storage_sync_mgmt_cloud_endpoints_operations.py:1

  • The newly added update test doesn’t assert anything about the returned result (and response isn’t validated). To make this test meaningful, add at least a minimal assertion (e.g., non-null response and/or that change_enumeration_interval_days reflects the update when the service returns it).
    sdk/storage/azure-mgmt-storagesync/generated_tests/test_storage_sync_mgmt_cloud_endpoints_operations_async.py:1
  • Same as the sync variant: this new async update test has no assertions. Add a minimal validation of response and, if possible, verify the updated property on the returned CloudEndpoint to ensure the new operation is actually exercised.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread sdk/storage/azure-mgmt-storagesync/api.md
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 3f1ab584-1bba-44a3-ac54-43dee4f2b16a
Copilot AI review requested due to automatic review settings August 14, 2026 02:47
@ChenxiJiang333 ChenxiJiang333 added the mgmt-review-needed PR for Mgmt SDK is ready to review label Aug 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 69 out of 69 changed files in this pull request and generated no new comments.

@ChenxiJiang333 ChenxiJiang333 added mgmt-review-needed PR for Mgmt SDK is ready to review and removed mgmt-review-needed PR for Mgmt SDK is ready to review labels Aug 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Management SDK PR review

Findings: None.

Unverified checks

Unverified checks: None.

Review summary

Affected package: sdk/storage/azure-mgmt-storagesync.

Checks completed:

  • API version consistency: _metadata.json apiVersion unchanged (2025-12-01) between first (307ed04) and latest (1b58e985a) revisions.
  • Version consistency: _version.py VERSION 2.1.0 matches latest CHANGELOG.md entry 2.1.0 (2026-08-13).
  • Changelog date: release date 2026-08-13 is not more than 3 weeks in the future from current date; no reminder needed.
  • Preview API version check: N/A, API version 2025-12-01 is not a preview version; _version.py correctly uses stable 2.1.0.
  • pyproject.toml stability flags: version is stable (no b); is_stable = true and classifiers include Development Status :: 5 - Production/Stable — consistent.
  • Client signature: StorageSyncMgmtClient.__init__ in _client.py has credential, subscription_id, base_url in the required order; subscription_id is present so no_sub is correctly absent from pyproject.toml.
  • Client name consistency: StorageSyncMgmtClient used consistently in _client.py, README.md, and pyproject.toml (title).
  • README code snippets: sample client instantiation matches actual __init__ signature (credential, subscription_id).

Scope exclusions applied: generated samples/tests and generated source files other than _client.py were not reviewed.

@ChenxiJiang333 ChenxiJiang333 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ankush Bindlish (@ankushbindlish2), we have approved the PR. You can move on to merge and release though the action suggestion in Release Plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-release When merged to main, release pipelines for this PR's changed packages trigger automatically. mgmt-review-needed PR for Mgmt SDK is ready to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants