Sync eng/common directory with azure-sdk-tools for PR 16724 - #48576
Merged
azure-sdk-automation[bot] merged 1 commit intoAug 13, 2026
Merged
Conversation
Route vcpkg asset (source tarball) downloads through the Microsoft-hosted Terrapin mirror instead of the azuresdkartifacts storage account, so vcpkg builds fetch upstream sources from an approved mirror under network isolation. set-vcpkg-cache-vars.yml now sets X_VCPKG_ASSET_SOURCES to the Terrapin mirror with x-block-origin, which fails the build if a source is missing from the mirror rather than silently falling back to the public internet. The value is no longer a secret because it carries no SAS token, so it can be set directly instead of being plumbed through X_VCPKG_ASSET_SOURCES_SECRET. Set-VcpkgWriteModeCache.ps1 no longer sets a write-mode asset source. That line overrode the read-only Terrapin mirror in internal builds and would have sent asset downloads back to the storage account. The binary cache is unchanged and remains read/write there. The tools-local copy at eng/scripts/Set-VcpkgWriteModeCache.ps1 is not synced to language repos and is left alone. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f3a428db-e276-4363-afd9-a944e8533203
azure-sdk-automation
Bot
added
EngSys
|
Azure Pipelines: Successfully started running 1 pipeline(s). 9 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
Updates Azure Pipelines vcpkg cache variable setup to stop configuring the legacy “asset cache secret” variable and instead point assets at a vcpkg source mirror.
Changes:
- Remove setting
X_VCPKG_ASSET_SOURCES_SECRETin the write-mode PowerShell helper script - Update the pipeline step to set
X_VCPKG_ASSET_SOURCES(non-secret) to a vcpkg source mirror and adjust logging messages
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| eng/common/scripts/Set-VcpkgWriteModeCache.ps1 | Stops setting the legacy asset-source secret variable during write-mode configuration |
| eng/common/pipelines/templates/steps/set-vcpkg-cache-vars.yml | Switches asset configuration to X_VCPKG_ASSET_SOURCES pointing at the vcpkg mirror and updates messages |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Daniel Jurek (danieljurek)
approved these changes
Aug 13, 2026
azure-sdk-automation
Bot
deleted the
sync-eng-common-djurek/shared-vcpkg-config-16724
branch
August 13, 2026 20:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#16724 See eng/common workflow