Skip to content

Add PyPI fallback for APIStub wheel downloads - #48571

Open
Yuchao Yan (msyyc) wants to merge 2 commits into
mainfrom
fix/apistub-pypi-fallback
Open

Add PyPI fallback for APIStub wheel downloads#48571
Yuchao Yan (msyyc) wants to merge 2 commits into
mainfrom
fix/apistub-pypi-fallback

Conversation

@msyyc

@msyyc Yuchao Yan (msyyc) commented Aug 13, 2026

Copy link
Copy Markdown
Member

moved from #48570

Summary

  • try the Azure SDK package feed first when downloading a released wheel for APIStub generation
  • retry against public PyPI when the Azure SDK feed download fails
  • report and propagate the final error when both package indexes fail
  • add unit coverage for the primary feed, successful fallback, and final failure

Testing

  • python -m pytest eng/tools/azure-sdk-tools/tests/test_apistub.py -q (19 passed)
  • python -m black --check --config eng/black-pyproject.toml eng/tools/azure-sdk-tools/azpysdk/apistub.py eng/tools/azure-sdk-tools/tests/test_apistub.py

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
9 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@msyyc
Yuchao Yan (msyyc) marked this pull request as ready for review August 13, 2026 09:50
Copilot AI balanced review requested due to automatic review settings August 13, 2026 09:50
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
9 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds resilient APIStub wheel downloads by preferring the Azure SDK package feed and falling back to public PyPI.

Changes:

  • Adds sequential package-index fallback and failure logging.
  • Adds tests for primary download, fallback, and total failure.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
eng/tools/azure-sdk-tools/azpysdk/apistub.py Implements feed fallback behavior.
eng/tools/azure-sdk-tools/tests/test_apistub.py Covers the new download paths.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread eng/tools/azure-sdk-tools/azpysdk/apistub.py
Comment thread eng/tools/azure-sdk-tools/azpysdk/apistub.py Outdated
Copilot AI review requested due to automatic review settings August 13, 2026 10:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants