Skip to content

[AutoPR azure-mgmt-compute]-generated-from-SDK Generation - Python-6692529 - #48549

Open
azure-sdk-automation[bot] wants to merge 2 commits into
mainfrom
sdkauto/azure-mgmt-compute-6692529
Open

[AutoPR azure-mgmt-compute]-generated-from-SDK Generation - Python-6692529#48549
azure-sdk-automation[bot] wants to merge 2 commits into
mainfrom
sdkauto/azure-mgmt-compute-6692529

Conversation

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

Configurations: 'specification/compute/resource-manager/Microsoft.Compute/Compute/tspconfig.yaml', API Version: 2026-04-01, SDK Release Type: stable, and CommitSHA: 'f033bb63819c74607f4086c49ae7b07a22c35f78' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6692529 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=36009 Submitted by: haagha@microsoft.com

…pute/Compute/tspconfig.yaml', API Version: 2026-04-01, SDK Release Type: stable, and CommitSHA: 'f033bb63819c74607f4086c49ae7b07a22c35f78' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6692529 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Copilot AI balanced review requested due to automatic review settings August 12, 2026 17:28
@azure-sdk-automation azure-sdk-automation Bot added the auto-release When merged to main, release pipelines for this PR's changed packages trigger automatically. label Aug 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
9 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI review requested due to automatic review settings August 13, 2026 02:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@ChenxiJiang333 ChenxiJiang333 added the mgmt-review-needed PR for Mgmt SDK is ready to review label Aug 13, 2026

@ChenxiJiang333 ChenxiJiang333 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Haider Agha (@haagha), we have approved the PR. You can move on to merge and release though the action suggestion in Release Plan.

@github-actions

Copy link
Copy Markdown
Contributor

Management SDK PR review

Findings: None.

Unverified checks

Check Reason
API version drift (sdk/compute/azure-mgmt-compute/_metadata.json) Could not read apiVersion from _metadata.json at first revision e11525e7a2f8989d8cf6a4156d6adcd243c6a909 and latest revision 9bc9a3c25aa378521092e336acb4b85aab399fa1: 'apiVersion'. Note: this package's _metadata.json uses a multi-value apiVersions map (Compute: 2026-04-01, ComputeDisk: 2026-03-02, ComputeGallery: 2025-12-03, ComputeSku: 2021-07-01) rather than a single apiVersion key, so the automated drift check could not extract a comparable value. Manual confirmation that the intended API versions were bumped as expected is recommended.

Review summary

Affected package: sdk/compute/azure-mgmt-compute

Checks completed:

  • Version consistency: _version.py (38.3.0) matches the latest CHANGELOG.md entry (## 38.3.0 (2026-08-12)).
  • Changelog date: release date 2026-08-12 is not more than 3 weeks in the future — no reminder needed.
  • Pyproject stability flags: version has no b suffix (stable); is_stable = true and classifier "Development Status :: 5 - Production/Stable" are present — consistent.
  • Client signature: ComputeManagementClient.__init__ in _client.py declares credential, subscription_id, base_url in the required order; subscription_id is present so no_sub is not required.
  • Client name consistency: class name ComputeManagementClient matches README.md usage and pyproject.toml title.
  • README code snippets: sample in README.md matches the actual client constructor signature.

Not independently verifiable: exact per-service API version drift (see Unverified checks above).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-release When merged to main, release pipelines for this PR's changed packages trigger automatically. mgmt-review-needed PR for Mgmt SDK is ready to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants