Add management list return review rule - #50109
Open
Weidong Xu (weidongxu-microsoft) wants to merge 4 commits into
Open
Add management list return review rule#50109Weidong Xu (weidongxu-microsoft) wants to merge 4 commits into
Weidong Xu (weidongxu-microsoft) wants to merge 4 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8b3c7768-709f-4883-8412-db94c3895259
|
Azure Pipelines: Successfully started running 1 pipeline(s). 34 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8b3c7768-709f-4883-8412-db94c3895259
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8b3c7768-709f-4883-8412-db94c3895259
Use GitHub-shaped PR metadata and raw per-file patches for existing findings and true-negative cases. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8b3c7768-709f-4883-8412-db94c3895259
|
Azure Pipelines: Successfully started running 1 pipeline(s). 34 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Weidong Xu (weidongxu-microsoft)
August 12, 2026 11:15
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the management AutoPR reviewer ruleset to add a new warning signal (MGMT-LIST-RETURN) for newly introduced public list* operations that return a non-pageable model exposing a collection-valued value, and aligns the critic + eval coverage with that new rule and the newer “synthetic PR” eval input shape.
Changes:
- Added
MGMT-LIST-RETURNrule definition and validation requirements (including exclusions like response variants, protocol methods, helpers, and pre-existing operations). - Regenerated the gh-aw workflow lock after updating the workflow markdown guidance.
- Migrated eval fixtures from monolithic
review-input.mdsnapshots to materializedgithub-responses/*.json+pr-diff/*.diff, and added positive/true-negative coverage for the new rule.
Reviewed changes
Copilot reviewed 105 out of 105 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/management-autopr-review.md | Documents the new MGMT-LIST-RETURN rule ID, validation criteria, and severity expectations for workflow review. |
| .github/workflows/management-autopr-review.lock.yml | Regenerated gh-aw compiled lock to reflect the updated workflow markdown. |
| .github/skills/management-autopr-review/SKILL.md | Adds the MGMT-LIST-RETURN rule definition and updates output formatting guidance to code-format the full bracketed concern ID. |
| .github/skills/management-autopr-review/evals/true-negatives.eval.yaml | Updates true-negative evals to the synthetic-PR input layout and adds a true-negative case ensuring list/pageable shapes don’t trigger MGMT-LIST-RETURN. |
| .github/skills/management-autopr-review/evals/findings.eval.yaml | Updates findings evals to the synthetic-PR input layout and adds a positive case for MGMT-LIST-RETURN. |
| .github/agents/management-autopr-review-critic.agent.md | Extends critic validation rules and severity mapping to include MGMT-LIST-RETURN. |
| .github/skills/management-autopr-review/evals/fixtures/tn-service-folder-match.md | Removes legacy monolithic review-input.md fixture (replaced by PR JSON + per-file diffs). |
| .github/skills/management-autopr-review/evals/fixtures/tn-service-folder-match-pr.json | New synthetic PR fixture (PR metadata) for the service-folder true-negative case. |
| .github/skills/management-autopr-review/evals/fixtures/tn-service-folder-match-pom.diff | New per-file diff fixture for the service-folder true-negative case. |
| .github/skills/management-autopr-review/evals/fixtures/tn-service-folder-match-java.diff | New per-file diff fixture for the service-folder true-negative case. |
| .github/skills/management-autopr-review/evals/fixtures/tn-prior-concern.md | Removes legacy monolithic fixture for prior-concern carry-forward behavior. |
| .github/skills/management-autopr-review/evals/fixtures/tn-prior-concern-pr.json | New synthetic PR metadata fixture for prior-concern carry-forward eval. |
| .github/skills/management-autopr-review/evals/fixtures/tn-prior-concern-java.diff | New per-file diff fixture for prior-concern carry-forward eval. |
| .github/skills/management-autopr-review/evals/fixtures/tn-prior-concern-comments.json | New GitHub issue-comments fixture to validate dedup/carry-forward behavior. |
| .github/skills/management-autopr-review/evals/fixtures/tn-prior-concern-changelog.diff | New changelog diff fixture used by prior-concern carry-forward eval. |
| .github/skills/management-autopr-review/evals/fixtures/tn-manager-reordered.md | Removes legacy monolithic manager-name reordered fixture. |
| .github/skills/management-autopr-review/evals/fixtures/tn-manager-reordered-pr.json | New synthetic PR metadata fixture for reordered manager identity true-negative. |
| .github/skills/management-autopr-review/evals/fixtures/tn-manager-reordered-java.diff | New per-file diff fixture for reordered manager identity true-negative. |
| .github/skills/management-autopr-review/evals/fixtures/tn-manager-legacy.md | Removes legacy monolithic manager legacy-name fixture. |
| .github/skills/management-autopr-review/evals/fixtures/tn-manager-legacy-pr.json | New synthetic PR metadata fixture for legacy manager true-negative. |
| .github/skills/management-autopr-review/evals/fixtures/tn-manager-legacy-java.diff | New per-file diff fixture for legacy manager true-negative. |
| .github/skills/management-autopr-review/evals/fixtures/tn-manager-clean.md | Removes legacy monolithic “clean manager” fixture. |
| .github/skills/management-autopr-review/evals/fixtures/tn-manager-clean-pr.json | New synthetic PR metadata fixture for clean manager true-negative. |
| .github/skills/management-autopr-review/evals/fixtures/tn-manager-clean-java.diff | New per-file diff fixture for clean manager true-negative. |
| .github/skills/management-autopr-review/evals/fixtures/tn-generated-only-java.md | Removes legacy monolithic generated-only change fixture. |
| .github/skills/management-autopr-review/evals/fixtures/tn-generated-only-java.diff | New per-file diff fixture for generated-only change true-negative. |
| .github/skills/management-autopr-review/evals/fixtures/tn-generated-only-java-pr.json | New synthetic PR metadata fixture for generated-only change true-negative. |
| .github/skills/management-autopr-review/evals/fixtures/tn-beta-breaking-changelog.md | Removes legacy monolithic beta-breaking-changelog fixture. |
| .github/skills/management-autopr-review/evals/fixtures/tn-beta-breaking-changelog-pr.json | New synthetic PR metadata fixture for beta-breaking-changelog true-negative. |
| .github/skills/management-autopr-review/evals/fixtures/tn-beta-breaking-changelog-pom.diff | New per-file diff fixture for beta-breaking-changelog true-negative. |
| .github/skills/management-autopr-review/evals/fixtures/tn-beta-breaking-changelog-java.diff | New per-file diff fixture for beta-breaking-changelog true-negative. |
| .github/skills/management-autopr-review/evals/fixtures/tn-beta-breaking-changelog-changelog.diff | New changelog diff fixture for beta-breaking-changelog true-negative. |
| .github/skills/management-autopr-review/evals/fixtures/tn-additive-beta-update-pr.json | New synthetic PR metadata fixture for additive beta update true-negative. |
| .github/skills/management-autopr-review/evals/fixtures/tn-additive-beta-update-pom.diff | New per-file diff fixture for additive beta update true-negative. |
| .github/skills/management-autopr-review/evals/fixtures/tn-additive-beta-update-changelog.diff | New changelog diff fixture for additive beta update true-negative. |
| .github/skills/management-autopr-review/evals/fixtures/tn-additive-beta-update-java.diff | New per-file diff fixture for additive beta update true-negative. |
| .github/skills/management-autopr-review/evals/fixtures/tn-additive-beta-update-model.diff | New per-file diff fixture (model) for additive beta update true-negative. |
| .github/skills/management-autopr-review/evals/fixtures/tn-list-return-pr.json | New synthetic PR metadata fixture for list-return true-negative coverage. |
| .github/skills/management-autopr-review/evals/fixtures/tn-list-return-public.diff | New per-file diff fixture for list-return true-negative (pageable + non-pageable helpers). |
| .github/skills/management-autopr-review/evals/fixtures/tn-list-return-async.diff | New per-file diff fixture for list-return true-negative (async pageable). |
| .github/skills/management-autopr-review/evals/fixtures/tn-list-return-keys.diff | New per-file diff fixture for list-return true-negative (non-pageable action response). |
| .github/skills/management-autopr-review/evals/fixtures/tn-list-return-credentials.diff | New per-file diff fixture for list-return true-negative (non-pageable action response). |
| .github/skills/management-autopr-review/evals/fixtures/tn-list-return-implementation.diff | New per-file diff fixture for list-return true-negative (protocol/response/helper exclusions). |
| .github/skills/management-autopr-review/evals/fixtures/positive-version.md | Removes legacy monolithic “positive version” fixture. |
| .github/skills/management-autopr-review/evals/fixtures/positive-version-pr.json | New synthetic PR metadata fixture for positive version finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-version-pom.diff | New per-file diff fixture for positive version finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-version-java.diff | New per-file diff fixture for positive version finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-version-changelog.diff | New changelog diff fixture for positive version finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-version-changelog-map.md | Removes legacy monolithic changelog-map fixture. |
| .github/skills/management-autopr-review/evals/fixtures/positive-version-changelog-map-pr.json | New synthetic PR metadata fixture for changelog-map version finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-version-changelog-map-pom.diff | New per-file diff fixture for changelog-map version finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-version-changelog-map-java.diff | New per-file diff fixture for changelog-map version finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-version-changelog-map-changelog.diff | New changelog diff fixture for changelog-map version finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-service-folder-mismatch.md | Removes legacy monolithic service-folder mismatch fixture. |
| .github/skills/management-autopr-review/evals/fixtures/positive-service-folder-mismatch-pr.json | New synthetic PR metadata fixture for service-folder mismatch finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-service-folder-mismatch-pom.diff | New per-file diff fixture for service-folder mismatch finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-service-folder-mismatch-java.diff | New per-file diff fixture for service-folder mismatch finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-new-module.md | Removes legacy monolithic new-module fixture. |
| .github/skills/management-autopr-review/evals/fixtures/positive-new-module-pr.json | New synthetic PR metadata fixture for new-module finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-new-module-pom.diff | New per-file diff fixture for new-module finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-new-module-java.diff | New per-file diff fixture for new-module finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-missing-release-plan.md | Removes legacy monolithic missing-release-plan fixture. |
| .github/skills/management-autopr-review/evals/fixtures/positive-missing-release-plan-pr.json | New synthetic PR metadata fixture for missing-release-plan finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-missing-release-plan-java.diff | New per-file diff fixture for missing-release-plan finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-manager-unrelated.md | Removes legacy monolithic “manager unrelated” fixture. |
| .github/skills/management-autopr-review/evals/fixtures/positive-manager-unrelated-pr.json | New synthetic PR metadata fixture for “manager unrelated” finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-manager-unrelated-java.diff | New per-file diff fixture for “manager unrelated” finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-manager-spelling.md | Removes legacy monolithic “manager spelling” fixture. |
| .github/skills/management-autopr-review/evals/fixtures/positive-manager-spelling-pr.json | New synthetic PR metadata fixture for “manager spelling” finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-manager-spelling-java.diff | New per-file diff fixture for “manager spelling” finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-manager-casing.md | Removes legacy monolithic “manager casing” fixture. |
| .github/skills/management-autopr-review/evals/fixtures/positive-manager-casing-pr.json | New synthetic PR metadata fixture for “manager casing” finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-manager-casing-java.diff | New per-file diff fixture for “manager casing” finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-folder.md | Removes legacy monolithic folder finding fixture. |
| .github/skills/management-autopr-review/evals/fixtures/positive-folder-pr.json | New synthetic PR metadata fixture for folder finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-folder-pom.diff | New per-file diff fixture for folder finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-folder-java.diff | New per-file diff fixture for folder finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-breaking.md | Removes legacy monolithic breaking finding fixture. |
| .github/skills/management-autopr-review/evals/fixtures/positive-breaking-pr.json | New synthetic PR metadata fixture for breaking finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-breaking-pom.diff | New per-file diff fixture for breaking finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-breaking-java.diff | New per-file diff fixture for breaking finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-breaking-changelog.diff | New changelog diff fixture for breaking finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-api-version-overlap.md | Removes legacy monolithic api-version-overlap fixture. |
| .github/skills/management-autopr-review/evals/fixtures/positive-api-version-overlap-pr.json | New synthetic PR metadata fixture for api-version-overlap finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-api-version-overlap-java.diff | New per-file diff fixture for api-version-overlap finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-api-version-overlap-changelog.diff | New changelog diff fixture for api-version-overlap finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-api-version-metadata-map.md | Removes legacy monolithic metadata-map fixture. |
| .github/skills/management-autopr-review/evals/fixtures/positive-api-version-metadata-map-pr.json | New synthetic PR metadata fixture for metadata-map finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-api-version-metadata-map-pom.diff | New per-file diff fixture for metadata-map finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-api-version-metadata-map-java.diff | New per-file diff fixture for metadata-map finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-api-version-metadata-map-metadata.diff | New per-file diff fixture for metadata-map finding (metadata json). |
| .github/skills/management-autopr-review/evals/fixtures/positive-api-version-metadata-map-changelog.diff | New changelog diff fixture for metadata-map finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-api-version-changed.md | Removes legacy monolithic api-version-changed fixture. |
| .github/skills/management-autopr-review/evals/fixtures/positive-api-version-changed-pr.json | New synthetic PR metadata fixture for api-version-changed finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-api-version-changed-java.diff | New per-file diff fixture for api-version-changed finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-api-version-changed-comments.json | New issue-comments fixture for api-version-changed “re-emit as New” behavior. |
| .github/skills/management-autopr-review/evals/fixtures/positive-api-version-changed-changelog.diff | New changelog diff fixture for api-version-changed finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-lro-pr.json | New synthetic PR metadata fixture for LRO finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-lro-method.diff | New per-file diff fixture for LRO finding (method shape). |
| .github/skills/management-autopr-review/evals/fixtures/positive-lro-response.diff | New per-file diff fixture for LRO finding (Response type). |
| .github/skills/management-autopr-review/evals/fixtures/positive-lro-headers.diff | New per-file diff fixture for LRO finding (Headers type). |
| .github/skills/management-autopr-review/evals/fixtures/positive-list-return-pr.json | New synthetic PR metadata fixture for MGMT-LIST-RETURN positive finding. |
| .github/skills/management-autopr-review/evals/fixtures/positive-list-return-operation.diff | New per-file diff fixture for MGMT-LIST-RETURN positive finding (non-pageable list op). |
| .github/skills/management-autopr-review/evals/fixtures/positive-list-return-noise.diff | New per-file diff fixture providing unrelated churn/noise alongside the positive list-return case. |
| .github/skills/management-autopr-review/evals/fixtures/positive-list-return-model.diff | New per-file diff fixture for MGMT-LIST-RETURN positive finding (model exposes collection-valued value). |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Weidong Xu (weidongxu-microsoft)
requested a review
from Xiaofei Cao (XiaofeiCao)
August 12, 2026 11:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MGMT-LIST-RETURNfor newly added publiclist*operations whose non-pageable return model exposes a collection-valuedvaluePagedIterable<T>andPagedFlux<T>and treat models withoutvalueas genuine non-pageable action responsesVerification