feat: improve interactive configuration UX and prevent empty subscription values for Azure/avm-ptn-alz - #536
Open
Richard Cheney (richeney) wants to merge 2 commits into
Conversation
Improve the interactive configuration flow for a smoother user experience. - clarify the default-selection and manual-entry logic in the menu helper - make default subscription matching more intuitive for workload-style keys - preserve optional inputs without forcing a selection when the value is intentionally blank - avoid empty subscription IDs being passed through to downstream bootstrap and AVM configuration steps, preventing Terraform/bootstrap issues
Contributor
Author
|
The key fix is for the subscription_ids section of the inputs.yaml. Example: ## Decision 7: Platform Subscriptions
subscription_ids:
management: "50ace030-4f1f-4792-8efb-f0ccf40f4035"
identity: ""
connectivity: "72dab7e3-809b-4b71-b738-847d0e3cf601"
security: ""This causes downstream issues. The avm-ptn-alz Terraform module will error on duplicate or non-GUID values in the subscription_placement object. This PR updates the interactive experience in this module to ensure that any null or empty subscriptions are not created in the input.yaml. E.g.: ## Decision 7: Platform Subscriptions
subscription_ids:
management: "50ace030-4f1f-4792-8efb-f0ccf40f4035"
connectivity: "72dab7e3-809b-4b71-b738-847d0e3cf601" |
Contributor
Author
|
Additional user experience enhancements:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change improves the interactive configuration experience for accelerator setup and avoids downstream bootstrap issues caused by empty subscription values.
What changed
Why
The interactive configuration flow was occasionally forcing unnecessary choices or carrying empty subscription values into later steps. This update makes the prompts more user-friendly while protecting configuration generation from invalid or blank subscription data.