fix(aztec-nr): clarify fragmented balance error - #25286
Open
loglapa wants to merge 1 commit into
Open
Conversation
loglapa
marked this pull request as ready for review
August 23, 2026 08:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24984.
Summary
Clarify the
BalanceSet::subassertion when the selected notes do not cover the requested amount. The previousBalance too lowmessage was also emitted when the total balance was sufficient but too fragmented to fit within the note-read limit.The new message names both possible causes without hard-coding the current note limit, so it remains accurate if the protocol constant changes. The subtraction behavior is unchanged.
Testing
Using the repository-built
nargo 1.0.0-beta.26artifact in the ARM64aztecprotocol/build:3.0container:nargo fmt --check --package balance_setnargo check --package balance_set --deny-warningsnargo test --package balance_set(package currently contains no test functions; compilation succeeds)