refactor: split wallet fee option calculation - #25276
Open
loglapa wants to merge 2 commits into
Open
Conversation
loglapa
marked this pull request as ready for review
August 20, 2026 09:56
shiqicao
reviewed
Aug 21, 2026
loglapa
force-pushed
the
vl/split-base-wallet-fee-options
branch
from
August 21, 2026 08:29
001c05a to
51eaeeb
Compare
Author
|
The current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25239
Summary
FeeOptions remains as the internal entrypoint input because it also carries wallet-provided fee execution payloads outside the removed completion helper.
Testing
All commands ran against the built workspace in aztecprotocol/devbox:3.0.