Skip to content

refactor: split wallet fee option calculation - #25276

Open
loglapa wants to merge 2 commits into
AztecProtocol:merge-train/spartanfrom
loglapa:vl/split-base-wallet-fee-options
Open

refactor: split wallet fee option calculation#25276
loglapa wants to merge 2 commits into
AztecProtocol:merge-train/spartanfrom
loglapa:vl/split-base-wallet-fee-options

Conversation

@loglapa

@loglapa loglapa commented Aug 20, 2026

Copy link
Copy Markdown

Closes #25239

Summary

  • split the pure account fee-payment decision from asynchronous gas-settings calculation
  • remove CompleteFeeOptionsConfig and update BaseWallet subclasses to call the two operations independently
  • add focused coverage for every account fee-payment mode while preserving gas-limit validation coverage

FeeOptions remains as the internal entrypoint input because it also carries wallet-provided fee execution payloads outside the removed completion helper.

Testing

  • yarn build
  • yarn workspace @aztec/wallet-sdk test base-wallet/base_wallet.test.ts
  • yarn workspace @aztec/wallets test embedded/embedded_wallet.test.ts
  • yarn format wallet-sdk cli-wallet wallets end-to-end (run per package)
  • yarn lint wallet-sdk cli-wallet wallets end-to-end (run per package; end-to-end with an 8 GB Node heap)

All commands ran against the built workspace in aztecprotocol/devbox:3.0.

@loglapa
loglapa marked this pull request as ready for review August 20, 2026 09:56
Comment thread yarn-project/wallet-sdk/src/base-wallet/base_wallet.ts Outdated
@loglapa
loglapa force-pushed the vl/split-base-wallet-fee-options branch from 001c05a to 51eaeeb Compare August 21, 2026 08:29
@loglapa

loglapa commented Aug 21, 2026

Copy link
Copy Markdown
Author

The current ci-external failure is administrative only: the check reports that this external PR needs the ci-external or ci-external-once label. I attempted to add ci-external-once, but GitHub correctly rejected it because external contributors cannot add repository labels. A maintainer needs to add the label to start CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants