Skip to content

fix: add context to verification key size errors - #25272

Open
loglapa wants to merge 2 commits into
AztecProtocol:merge-train/spartanfrom
loglapa:vl/fix-vk-size-error-context
Open

fix: add context to verification key size errors#25272
loglapa wants to merge 2 commits into
AztecProtocol:merge-train/spartanfrom
loglapa:vl/fix-vk-size-error-context

Conversation

@loglapa

@loglapa loglapa commented Aug 20, 2026

Copy link
Copy Markdown

Fixes #25107.

Summary

  • Validate private-function verification key byte lengths while the contract and function names are still available.
  • Preserve the expected and actual byte counts and suggest rebuilding stale or incompatible artifacts.
  • Add a regression test for the contextual error message.

Testing

  • make yarn-project in aztecprotocol/devbox:3.0
  • yarn format stdlib
  • yarn workspace @aztec/stdlib test src/abi/contract_artifact.test.ts (7 tests passed)
  • git diff --check

@loglapa
loglapa marked this pull request as ready for review August 20, 2026 10:28
Vladislav Lapin added 2 commits August 21, 2026 14:36
Signed-off-by: Vladislav Lapin <v.lapin@scalablesolutions.io>
Signed-off-by: Vladislav Lapin <v.lapin@scalablesolutions.io>
@loglapa
loglapa force-pushed the vl/fix-vk-size-error-context branch from 1740de1 to 833459d Compare August 21, 2026 10:56
@loglapa

loglapa commented Aug 21, 2026

Copy link
Copy Markdown
Author

Rebased onto the current merge-train/spartan tip. Validation in aztecprotocol/devbox:3.0: immutable install, full TypeScript build, the focused contract_artifact.test.ts suite (7/7), format check, lint, and git diff --check all pass. The repository-wide bootstrap reaches the unchanged ipc-runtime prerequisite and stops because this devbox warns that Rust 1.89.0 is not installed; the yarn-project build and changed tests are green. A maintainer still needs to add ci-external-once (contributors cannot add repository labels).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant