Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion astrbot/core/provider/sources/gemini_source.py
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,7 @@ def append_or_extend(
append_or_extend(gemini_contents, parts, types.UserContent)

if gemini_contents and isinstance(gemini_contents[0], types.ModelContent):
gemini_contents.pop()
gemini_contents.pop(0)

return gemini_contents

Expand Down
63 changes: 62 additions & 1 deletion tests/test_gemini_source.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,74 @@

import httpx
import pytest
from google.genai import types

from astrbot.core.exceptions import EmptyModelOutputError
import astrbot.core.provider.sources.request_retry as request_retry
from astrbot.core.exceptions import EmptyModelOutputError
from astrbot.core.provider.entities import LLMResponse
from astrbot.core.provider.sources.gemini_source import ProviderGoogleGenAI


Comment thread
SunmiJJW marked this conversation as resolved.
def test_gemini_prepare_conversation_removes_leading_model_content():
provider = ProviderGoogleGenAI.__new__(ProviderGoogleGenAI)

contents = provider._prepare_conversation(
{
"messages": [
{"role": "assistant", "content": "stale assistant turn"},
{"role": "user", "content": "current user turn"},
]
}
)

assert len(contents) == 1
assert isinstance(contents[0], types.UserContent)
assert contents[0].parts is not None
assert contents[0].parts[-1].text == "current user turn"


def test_gemini_prepare_conversation_keeps_normal_user_first_history():
provider = ProviderGoogleGenAI.__new__(ProviderGoogleGenAI)

contents = provider._prepare_conversation(
{
"messages": [
{"role": "user", "content": "first user turn"},
{"role": "assistant", "content": "assistant turn"},
{"role": "user", "content": "current user turn"},
]
Comment thread
sourcery-ai[bot] marked this conversation as resolved.
}
)

assert [type(content) for content in contents] == [
types.UserContent,
types.ModelContent,
types.UserContent,
]
assert contents[-1].parts is not None
assert contents[-1].parts[-1].text == "current user turn"


def test_gemini_prepare_conversation_preserves_user_model_history():
provider = ProviderGoogleGenAI.__new__(ProviderGoogleGenAI)

contents = provider._prepare_conversation(
{
"messages": [
{"role": "user", "content": "user turn"},
{"role": "assistant", "content": "assistant turn"},
]
}
)

assert [type(content) for content in contents] == [
types.UserContent,
types.ModelContent,
]
assert contents[-1].parts is not None
assert contents[-1].parts[-1].text == "assistant turn"


def test_gemini_empty_output_raises_empty_model_output_error():
llm_response = LLMResponse(role="assistant")

Expand Down
Loading