Skip to content

fix: incorrect annotation of rewards - #74

Draft
arjunsridhar12345 wants to merge 7 commits into
devfrom
73-incorrect-annotation-of-rewards
Draft

fix: incorrect annotation of rewards#74
arjunsridhar12345 wants to merge 7 commits into
devfrom
73-incorrect-annotation-of-rewards

Conversation

@arjunsridhar12345

@arjunsridhar12345 arjunsridhar12345 commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Attempts to close #73. Running on the same session as the one in #73, there are now 248 unignored trials which lines up with the metadata, and 23 auto water R that are not earned reward which should line up as seen here: https://github.com/AllenNeuralDynamics/DF-Refactoring/issues/155. I ran the 08_11_864253_auto_water_check.ipynb notebook with an nwb generated from this branch. In addition, the warnings are gone now so maybe this fixes those also

Updates made:

  • Use response software event to correlate with the valve opening. Using this index mapping, use the trial outcome to determine if the trial was rewarded or not. Logic for earned and auto annotation then remains the same

The docstrings and comments are probably excessive and some of it is AI generated but it helped me understand the logic so I'm inclined to keep it

Comment thread src/dynamic_foraging_processing/utils/rewards.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants