Skip to content

[PWGLF] Fix MC mask bug hStrangeCorrelation.cxx - #17278

Merged
romainschotter merged 1 commit into
AliceO2Group:masterfrom
kcui1:MCMaskFix
Jul 31, 2026
Merged

[PWGLF] Fix MC mask bug hStrangeCorrelation.cxx#17278
romainschotter merged 1 commit into
AliceO2Group:masterfrom
kcui1:MCMaskFix

Conversation

@kcui1

@kcui1 kcui1 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

using bit check to do its-tpc mismatch
fix bug in opposite correlation in closure test

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 12 errors, ⚠️ 2 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Fix MC mask bug hStrangeCorrelation.cxx [PWGLF] Fix MC mask bug hStrangeCorrelation.cxx Jul 31, 2026
@romainschotter
romainschotter enabled auto-merge (squash) July 31, 2026 14:57
@romainschotter
romainschotter merged commit 9447803 into AliceO2Group:master Jul 31, 2026
13 of 15 checks passed
@alibuild

alibuild commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for b1f8a58 at 2026-08-01 09:42:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 18 errors and 0 warnings.'
Found 18 errors and 0 warnings.
++ [[ 18 -gt 0 ]]
++ cat /sw/BUILD/a2c346e2f1f9450b0f0f4ab421a773f7ad08abcc/O2Physics-code-check/errors.txt
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:89:8: error: constructor does not initialize these fields: ccdb, pdgDB [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:789:5: error: Variable 'r' with floating point type 'double' should not be used as a loop counter [clang-analyzer-security.FloatLoopCounter,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:2278:9: error: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:2440:9: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:2543:9: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:2694:9: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:2849:9: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:2934:11: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:2991:13: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3050:13: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3100:11: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3203:13: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3233:9: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3409:13: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3416:9: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3683:9: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3713:9: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/Utils/inelGt.h:117:11: error: using integer absolute value function 'abs' when argument is of floating point type [clang-diagnostic-absolute-value,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 18 -gt 0 ]]
++ exit 1
--

Full log here.

@kcui1
kcui1 deleted the MCMaskFix branch August 14, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants