DPL Analysis: Fix DECLARE_SOA_CCDB_COLUMN_FULL's default construcor w… - #15679
Open
mhemmer-cern wants to merge 1 commit into
Open
DPL Analysis: Fix DECLARE_SOA_CCDB_COLUMN_FULL's default construcor w…#15679mhemmer-cern wants to merge 1 commit into
mhemmer-cern wants to merge 1 commit into
Conversation
…hich was firing `cppcoreguidelines-pro-type-member-init` in O2Physics code when used
Contributor
Author
|
This got triggered when the clang-tidy settings in O2Physics got changed: AliceO2Group/O2Physics#16868 |
Contributor
Author
Member
|
Isn't this an issue with the linter? |
Contributor
Author
|
I mean yeah sure it was clang-tidy that stated the issue. From my understanding this way Column is not left not initialize. I don't know if the default constructor is an actual problem that needs fixing, but if it silents the linter, shouldn't it be fine? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…hich was firing
cppcoreguidelines-pro-type-member-initin O2Physics code when used.The concrete error was:
Constructor does not initialize these bases: Column