fix: resolve all 34 Dependabot alerts - #212
Merged
Merged
Conversation
- Bump pnpm overrides: axios 1.18.0, js-yaml 3.15.1/4.3.1, postcss 8.5.23, undici 6.28.0, shell-quote 1.9.0, @remix-run/router 1.23.3; add body-parser 1.20.6 and tsx 4.23.12 (removes vulnerable esbuild 0.23.1 pulled in via @tanstack/router-generator) - Update ofetch packageExtension to undici 6.28.0 - docs: upgrade astro 6 -> 7.2.0 with @astrojs/starlight 0.41.7 and sharp 0.35.3 (also removes vulnerable esbuild 0.27.7) The two remaining react-router 6.30.4 alerts have no patched 6.x release (fixes only exist in >= 7.18.0); 6.30.4 is the latest 6.x.
The two remaining Dependabot alerts (open redirect and constructor injection in react-router < 7.18.0) are only fixed in 7.x; react-router 6.30.4 is the final 6.x release with no backport. Removing the example drops the vulnerable dependency entirely, along with the now-unneeded react-router@6 and @remix-run/router pnpm overrides. The react-router-7 example remains.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Coverage Report
File CoverageNo changed files found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes all 34 open Dependabot alerts across the repo.
Dependency bumps (32 alerts)
Most alerts came from stale
pnpm.overridesentries in the rootpackage.json:axiosjs-yaml@3/js-yaml@4postcssundicishell-quotebody-parsertsxThe
ofetchpackageExtensionsentry was bumped toundici6.28.0 to match. The newtsxoverride evicts the vulnerableesbuild0.23.1 that@tanstack/router-generatorwas pulling in.The docs site was bumped from Astro 6 to 7 (
astro^7.2.0,@astrojs/starlight^0.41.7,sharp^0.35.3), which covers 8 alerts and also removes the vulnerableesbuild0.27.7. This was flagged as a potentially disruptive major bump, butastro check && astro buildpassed with no config changes needed.Removing the react-router 6 example (2 alerts)
The remaining two alerts (open redirect via backslash in
<Link>/useNavigate, and arbitrary constructor injection viadeserializeErrors()) are only fixed in react-router >= 7.18.0.react-router6.30.4 is the final 6.x release and there is no backport, so no override could resolve them.Since
examples/react-router-6-appwas the only consumer, the example has been removed along with its docs page and the now-unneededreact-router@6/@remix-run/routeroverrides. Thereact-router-7-appexample remains and covers the same integration pattern.Verification
pnpm test— 187 tests passingpnpm biome check .— cleantsc --noEmitin react-app, nextjs-app, tanstack-router-app — cleanpnpm --filter nextjs-app build— succeedsastro check && astro buildindocs/— succeedsNotes for reviewers
The main judgement call here is dropping the react-router 6 example rather than dismissing the two alerts as "no patch available." If you would rather keep 6.x coverage for users still on that version, revert the second commit and dismiss alerts #316 and #317 instead.