From e488c06458c6d6f8ad41be08d5511f072cdbf4ae Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 13 Aug 2026 06:38:45 +0000 Subject: [PATCH] test: migrate `stats/base/dists/logistic/entropy` to ULP-based assertions Replace relative tolerance assertions with ULP-based assertions using `@stdlib/assert/is-almost-same-value`. All fixture values are returned exactly by both the JavaScript and native implementations, so the required ULP bound is 0. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01G3SrW8juEFjGc5kVqJDtR1 --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../stats/base/dists/logistic/entropy/test/test.js | 13 ++----------- .../base/dists/logistic/entropy/test/test.native.js | 13 ++----------- 2 files changed, 4 insertions(+), 22 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/logistic/entropy/test/test.js b/lib/node_modules/@stdlib/stats/base/dists/logistic/entropy/test/test.js index 84dd79832784..cf75b0ebb611 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/logistic/entropy/test/test.js +++ b/lib/node_modules/@stdlib/stats/base/dists/logistic/entropy/test/test.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var entropy = require( './../lib' ); @@ -76,8 +75,6 @@ tape( 'if provided a nonpositive `s`, the function returns `NaN`', function test tape( 'the function returns the differential entropy of a logistic distribution', function test( t ) { var expected; - var delta; - var tol; var mu; var s; var y; @@ -89,13 +86,7 @@ tape( 'the function returns the differential entropy of a logistic distribution' for ( i = 0; i < mu.length; i++ ) { y = entropy( mu[i], s[i] ); if ( expected[i] !== null ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'mu:'+mu[i]+', s: '+s[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 2.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. mu: '+mu[i]+'. s: '+s[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } } t.end(); diff --git a/lib/node_modules/@stdlib/stats/base/dists/logistic/entropy/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/logistic/entropy/test/test.native.js index 873c5f520cf1..776387b9f3e9 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/logistic/entropy/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/logistic/entropy/test/test.native.js @@ -22,12 +22,11 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var tryRequire = require( '@stdlib/utils/try-require' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // VARIABLES // @@ -88,8 +87,6 @@ tape( 'if provided a nonpositive `s`, the function returns `NaN`', opts, functio tape( 'the function returns the differential entropy of a logistic distribution', opts, function test( t ) { var expected; - var delta; - var tol; var mu; var s; var y; @@ -101,13 +98,7 @@ tape( 'the function returns the differential entropy of a logistic distribution' for ( i = 0; i < mu.length; i++ ) { y = entropy( mu[i], s[i] ); if ( expected[i] !== null ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'mu:'+mu[i]+', s: '+s[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 2.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. mu: '+mu[i]+'. s: '+s[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } } t.end();