From 6a2cc808ccfb0470c80e0dab42f0e9ec3f6abbac Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 12 Aug 2026 10:21:39 +0000 Subject: [PATCH] test: migrate `stats/base/dists/negative-binomial/logpmf` to ULP-based assertions Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01WqbmGdvGjziBtU3pQnBwDi --- .../logpmf/test/test.factory.js | 43 +++---------------- .../logpmf/test/test.logpmf.js | 43 +++---------------- 2 files changed, 10 insertions(+), 76 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/negative-binomial/logpmf/test/test.factory.js b/lib/node_modules/@stdlib/stats/base/dists/negative-binomial/logpmf/test/test.factory.js index d74b251f96aa..6f08b7e9e619 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/negative-binomial/logpmf/test/test.factory.js +++ b/lib/node_modules/@stdlib/stats/base/dists/negative-binomial/logpmf/test/test.factory.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var factory = require( './../lib/factory.js' ); @@ -175,8 +174,6 @@ tape( 'if provided a `r` which is not a positive number, the created function al tape( 'the created function evaluates the logpmf for `x` given large `r` and `p`', function test( t ) { var expected; var logpmf; - var delta; - var tol; var x; var r; var p; @@ -190,13 +187,7 @@ tape( 'the created function evaluates the logpmf for `x` given large `r` and `p` for ( i = 0; i < x.length; i++ ) { logpmf = factory( r[i], p[i] ); y = logpmf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', r: '+r[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 80.0 * EPS * abs( expected[i] ); - t.strictEqual( delta <= tol, true, 'within tolerance. x: '+x[i]+'. r: '+r[i]+'. p: '+p[i]+'. y: '+y+'. Expected: '+expected[i]+'. tol: '+tol+'. delta: '+delta+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 109 ), true, 'returns expected value' ); } t.end(); }); @@ -204,8 +195,6 @@ tape( 'the created function evaluates the logpmf for `x` given large `r` and `p` tape( 'the created function evaluates the logpmf for `x` given a large parameter `r` and small `p`', function test( t ) { var expected; var logpmf; - var delta; - var tol; var i; var r; var p; @@ -219,13 +208,7 @@ tape( 'the created function evaluates the logpmf for `x` given a large parameter for ( i = 0; i < x.length; i++ ) { logpmf = factory( r[i], p[i] ); y = logpmf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', r: '+r[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 10.0 * EPS * abs( expected[i] ); - t.strictEqual( delta <= tol, true, 'within tolerance. x: '+x[i]+'. r: '+r[i]+'. p: '+p[i]+'. y: '+y+'. Expected: '+expected[i]+'. tol: '+tol+'. delta: '+delta+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 9 ), true, 'returns expected value' ); } t.end(); }); @@ -233,8 +216,6 @@ tape( 'the created function evaluates the logpmf for `x` given a large parameter tape( 'the created function evaluates the logpmf for `x` given small `r` and large parameter `p`', function test( t ) { var expected; var logpmf; - var delta; - var tol; var i; var r; var p; @@ -248,13 +229,7 @@ tape( 'the created function evaluates the logpmf for `x` given small `r` and lar for ( i = 0; i < x.length; i++ ) { logpmf = factory( r[i], p[i] ); y = logpmf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', r: '+r[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 40.0 * EPS * abs( expected[i] ); - t.strictEqual( delta <= tol, true, 'within tolerance. x: '+x[i]+'. r: '+r[i]+'. p: '+p[i]+'. y: '+y+'. Expected: '+expected[i]+'. tol: '+tol+'. delta: '+delta+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 57 ), true, 'returns expected value' ); } t.end(); }); @@ -262,8 +237,6 @@ tape( 'the created function evaluates the logpmf for `x` given small `r` and lar tape( 'the created function evaluates the logpmf for `x` given small `r` and `p`', function test( t ) { var expected; var logpmf; - var delta; - var tol; var i; var r; var p; @@ -277,13 +250,7 @@ tape( 'the created function evaluates the logpmf for `x` given small `r` and `p` for ( i = 0; i < x.length; i++ ) { logpmf = factory( r[i], p[i] ); y = logpmf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', r: '+r[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 10.0 * EPS * abs( expected[i] ); - t.strictEqual( delta <= tol, true, 'within tolerance. x: '+x[i]+'. r: '+r[i]+'. p: '+p[i]+'. y: '+y+'. Expected: '+expected[i]+'. tol: '+tol+'. delta: '+delta+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 6 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/negative-binomial/logpmf/test/test.logpmf.js b/lib/node_modules/@stdlib/stats/base/dists/negative-binomial/logpmf/test/test.logpmf.js index ebcbc64213aa..c86877ebcc66 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/negative-binomial/logpmf/test/test.logpmf.js +++ b/lib/node_modules/@stdlib/stats/base/dists/negative-binomial/logpmf/test/test.logpmf.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var logpmf = require( './../lib' ); @@ -122,8 +121,6 @@ tape( 'if provided a success probability `p` outside of `[0,1]`, the function re tape( 'the function evaluates the logpmf for `x` given large `r` and `p`', function test( t ) { var expected; - var delta; - var tol; var i; var r; var p; @@ -136,21 +133,13 @@ tape( 'the function evaluates the logpmf for `x` given large `r` and `p`', funct p = highHigh.p; for ( i = 0; i < x.length; i++ ) { y = logpmf( x[i], r[i], p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', r: '+r[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 80.0 * EPS * abs( expected[i] ); - t.strictEqual( delta <= tol, true, 'within tolerance. x: '+x[i]+'. r: '+r[i]+'. p: '+p[i]+'. y: '+y+'. Expected: '+expected[i]+'. tol: '+tol+'. delta: '+delta+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 109 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the logpmf for `x` given large parameter `r` and small `p`', function test( t ) { var expected; - var delta; - var tol; var i; var r; var p; @@ -163,21 +152,13 @@ tape( 'the function evaluates the logpmf for `x` given large parameter `r` and s p = highSmall.p; for ( i = 0; i < x.length; i++ ) { y = logpmf( x[i], r[i], p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', r: '+r[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 10.0 * EPS * abs( expected[i] ); - t.strictEqual( delta <= tol, true, 'within tolerance. x: '+x[i]+'. r: '+r[i]+'. p: '+p[i]+'. y: '+y+'. Expected: '+expected[i]+'. tol: '+tol+'. delta: '+delta+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 9 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the logpmf for `x` given small `r` and large `p`', function test( t ) { var expected; - var delta; - var tol; var i; var r; var p; @@ -190,21 +171,13 @@ tape( 'the function evaluates the logpmf for `x` given small `r` and large `p`', p = smallHigh.p; for ( i = 0; i < x.length; i++ ) { y = logpmf( x[i], r[i], p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', r: '+r[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 40.0 * EPS * abs( expected[i] ); - t.strictEqual( delta <= tol, true, 'within tolerance. x: '+x[i]+'. r: '+r[i]+'. p: '+p[i]+'. y: '+y+'. Expected: '+expected[i]+'. tol: '+tol+'. delta: '+delta+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 57 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the logpmf for `x` given small `r` and `p`', function test( t ) { var expected; - var delta; - var tol; var i; var r; var p; @@ -217,13 +190,7 @@ tape( 'the function evaluates the logpmf for `x` given small `r` and `p`', funct p = smallSmall.p; for ( i = 0; i < x.length; i++ ) { y = logpmf( x[i], r[i], p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', r: '+r[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = 10.0 * EPS * abs( expected[i] ); - t.strictEqual( delta <= tol, true, 'within tolerance. x: '+x[i]+'. r: '+r[i]+'. p: '+p[i]+'. y: '+y+'. Expected: '+expected[i]+'. tol: '+tol+'. delta: '+delta+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 6 ), true, 'returns expected value' ); } t.end(); });