|
| 1 | +/** |
| 2 | + * @vitest-environment node |
| 3 | + */ |
| 4 | +import type { Principal } from '@sim/auth/principal' |
| 5 | +import { beforeEach, describe, expect, it, vi } from 'vitest' |
| 6 | + |
| 7 | +const { mocks } = vi.hoisted(() => ({ |
| 8 | + mocks: { |
| 9 | + canSetPublicChatAuth: vi.fn(), |
| 10 | + validateChatDeployAuth: vi.fn(), |
| 11 | + resolveContext: vi.fn(), |
| 12 | + resolvePermission: vi.fn(), |
| 13 | + chatDeploy: vi.fn(), |
| 14 | + chatUndeploy: vi.fn(), |
| 15 | + audit: vi.fn(), |
| 16 | + }, |
| 17 | +})) |
| 18 | + |
| 19 | +vi.mock('@sim/audit', () => ({ |
| 20 | + AuditAction: { CHAT_DEPLOYED: 'chat.deployed', CHAT_UNDEPLOYED: 'chat.undeployed' }, |
| 21 | + AuditResourceType: { WORKFLOW: 'workflow' }, |
| 22 | + recordAudit: mocks.audit, |
| 23 | +})) |
| 24 | + |
| 25 | +vi.mock('@sim/platform-authz/workspace', () => ({ |
| 26 | + permissionSatisfies: (actual: string | null, required: string) => { |
| 27 | + const rank = { read: 1, write: 2, admin: 3 } as const |
| 28 | + return ( |
| 29 | + actual !== null && rank[actual as keyof typeof rank] >= rank[required as keyof typeof rank] |
| 30 | + ) |
| 31 | + }, |
| 32 | + resolveEffectiveWorkspacePermission: mocks.resolvePermission, |
| 33 | +})) |
| 34 | + |
| 35 | +vi.mock('@sim/db', () => { |
| 36 | + // Chainable stub: every existing-deployment lookup resolves to no rows, so the |
| 37 | + // use case takes the "new chat" path where authType defaults to public. |
| 38 | + const chain: Record<string, unknown> = {} |
| 39 | + for (const method of ['select', 'from', 'where', 'limit']) { |
| 40 | + chain[method] = vi.fn(() => chain) |
| 41 | + } |
| 42 | + ;(chain as { then?: unknown }).then = (resolve: (rows: unknown[]) => unknown) => resolve([]) |
| 43 | + return { db: chain, chat: { workflowId: {}, identifier: {}, archivedAt: {}, id: {} } } |
| 44 | +}) |
| 45 | + |
| 46 | +vi.mock('drizzle-orm', () => ({ |
| 47 | + and: vi.fn(), |
| 48 | + eq: vi.fn(), |
| 49 | + isNull: vi.fn(), |
| 50 | +})) |
| 51 | + |
| 52 | +vi.mock('@/lib/chat/permissions', () => ({ |
| 53 | + canSetPublicChatAuth: mocks.canSetPublicChatAuth, |
| 54 | +})) |
| 55 | + |
| 56 | +vi.mock('@/ee/access-control/utils/permission-check', () => { |
| 57 | + class ChatDeployAuthNotAllowedError extends Error {} |
| 58 | + return { validateChatDeployAuth: mocks.validateChatDeployAuth, ChatDeployAuthNotAllowedError } |
| 59 | +}) |
| 60 | + |
| 61 | +vi.mock('@/lib/workflows/application/context', () => ({ |
| 62 | + resolveActiveWorkflowApplicationContext: mocks.resolveContext, |
| 63 | +})) |
| 64 | + |
| 65 | +vi.mock('@/lib/workflows/orchestration', () => ({ |
| 66 | + performChatDeploy: mocks.chatDeploy, |
| 67 | + performChatUndeploy: mocks.chatUndeploy, |
| 68 | +})) |
| 69 | + |
| 70 | +import { deployWorkflowChat } from '@/lib/workflows/application/chat-deployments' |
| 71 | + |
| 72 | +const WRITE_PRINCIPAL: Principal = { |
| 73 | + kind: 'delegated', |
| 74 | + serviceId: 'copilot', |
| 75 | + subjectUserId: 'editor-1', |
| 76 | + workspaceId: 'workspace-1', |
| 77 | + delegationId: 'copilot-1', |
| 78 | + audience: 'sim:workflows', |
| 79 | + issuedAt: new Date('2026-08-08T00:00:00Z'), |
| 80 | + expiresAt: new Date('2999-08-08T00:00:00Z'), |
| 81 | +} |
| 82 | + |
| 83 | +/** |
| 84 | + * Chat deployment is `write`, but a public chat is invocable by anyone with the |
| 85 | + * URL and no auth, so the exposure is admin-only. This use case is the copilot |
| 86 | + * path and it defaults `authType` to `public`, which makes it the easiest place |
| 87 | + * for the boundary to be silently bypassed — the REST routes enforce it |
| 88 | + * separately. |
| 89 | + */ |
| 90 | +describe('copilot chat deploy cannot bypass the public-chat admin gate', () => { |
| 91 | + beforeEach(() => { |
| 92 | + vi.clearAllMocks() |
| 93 | + mocks.resolvePermission.mockResolvedValue('write') |
| 94 | + mocks.resolveContext.mockResolvedValue({ |
| 95 | + workflowId: 'workflow-1', |
| 96 | + workflow: { id: 'workflow-1', name: 'wf', userId: 'owner-1', workspaceId: 'workspace-1' }, |
| 97 | + workspaceId: 'workspace-1', |
| 98 | + workspaceOrganizationId: null, |
| 99 | + allowPersonalApiKeys: true, |
| 100 | + billedAccountUserId: 'billing-owner-1', |
| 101 | + }) |
| 102 | + mocks.chatDeploy.mockResolvedValue({ |
| 103 | + success: true, |
| 104 | + chatId: 'chat-1', |
| 105 | + chatUrl: 'http://localhost:3000/chat/x', |
| 106 | + }) |
| 107 | + }) |
| 108 | + |
| 109 | + it('rejects a write principal defaulting to public', async () => { |
| 110 | + mocks.canSetPublicChatAuth.mockResolvedValue(false) |
| 111 | + |
| 112 | + await expect( |
| 113 | + deployWorkflowChat.execute({ |
| 114 | + principal: WRITE_PRINCIPAL, |
| 115 | + input: { |
| 116 | + workflowId: 'workflow-1', |
| 117 | + identifier: 'my-chat', |
| 118 | + title: 'My Chat', |
| 119 | + versionName: 'v1', |
| 120 | + versionDescription: 'first', |
| 121 | + requestId: 'req-1', |
| 122 | + }, |
| 123 | + }) |
| 124 | + ).rejects.toMatchObject({ code: 'forbidden' }) |
| 125 | + |
| 126 | + expect(mocks.chatDeploy).not.toHaveBeenCalled() |
| 127 | + }) |
| 128 | + |
| 129 | + it('allows a write principal to deploy a password-protected chat', async () => { |
| 130 | + mocks.canSetPublicChatAuth.mockResolvedValue(false) |
| 131 | + |
| 132 | + await deployWorkflowChat.execute({ |
| 133 | + principal: WRITE_PRINCIPAL, |
| 134 | + input: { |
| 135 | + workflowId: 'workflow-1', |
| 136 | + identifier: 'my-chat', |
| 137 | + title: 'My Chat', |
| 138 | + authType: 'password', |
| 139 | + password: 'placeholder-value', |
| 140 | + versionName: 'v1', |
| 141 | + versionDescription: 'first', |
| 142 | + requestId: 'req-1', |
| 143 | + }, |
| 144 | + }) |
| 145 | + |
| 146 | + expect(mocks.chatDeploy).toHaveBeenCalled() |
| 147 | + expect(mocks.canSetPublicChatAuth).not.toHaveBeenCalled() |
| 148 | + }) |
| 149 | + |
| 150 | + it('allows an admin principal to deploy a public chat', async () => { |
| 151 | + mocks.canSetPublicChatAuth.mockResolvedValue(true) |
| 152 | + |
| 153 | + await deployWorkflowChat.execute({ |
| 154 | + principal: WRITE_PRINCIPAL, |
| 155 | + input: { |
| 156 | + workflowId: 'workflow-1', |
| 157 | + identifier: 'my-chat', |
| 158 | + title: 'My Chat', |
| 159 | + authType: 'public', |
| 160 | + versionName: 'v1', |
| 161 | + versionDescription: 'first', |
| 162 | + requestId: 'req-1', |
| 163 | + }, |
| 164 | + }) |
| 165 | + |
| 166 | + expect(mocks.chatDeploy).toHaveBeenCalledWith(expect.objectContaining({ authType: 'public' })) |
| 167 | + }) |
| 168 | +}) |
0 commit comments