From b291d957157c737ee6ac9574c1ea9c8c0ec077c2 Mon Sep 17 00:00:00 2001 From: Kurt Alfred Kluever Date: Thu, 13 Aug 2026 05:45:29 -0700 Subject: [PATCH] Fix duplicate blank lines before `MOE` end strip comment tag Reset `requestedWhitespace` to `NONE` when entering `writeMoeEndStripComment` in `JavadocWriter` so that any requested whitespace (e.g., from a preceding Markdown fenced code block) does not flush extra blank lines after `writeLineBreakNoAutoIndent` has already emitted a line break. PiperOrigin-RevId: 964030265 --- .../google/googlejavaformat/java/javadoc/JavadocWriter.java | 1 + .../google/googlejavaformat/java/JavadocFormattingTest.java | 3 --- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/core/src/main/java/com/google/googlejavaformat/java/javadoc/JavadocWriter.java b/core/src/main/java/com/google/googlejavaformat/java/javadoc/JavadocWriter.java index 31759b7c3..67b2eb195 100644 --- a/core/src/main/java/com/google/googlejavaformat/java/javadoc/JavadocWriter.java +++ b/core/src/main/java/com/google/googlejavaformat/java/javadoc/JavadocWriter.java @@ -331,6 +331,7 @@ void writeTableClose(TableCloseTag token) { } void writeMoeEndStripComment(MoeEndStripComment token) { + requestedWhitespace = NONE; writeLineBreakNoAutoIndent(); output.append(indentForMoeEndStripComment); diff --git a/core/src/test/java/com/google/googlejavaformat/java/JavadocFormattingTest.java b/core/src/test/java/com/google/googlejavaformat/java/JavadocFormattingTest.java index 84387e61d..5badf333c 100644 --- a/core/src/test/java/com/google/googlejavaformat/java/JavadocFormattingTest.java +++ b/core/src/test/java/com/google/googlejavaformat/java/JavadocFormattingTest.java @@ -1897,7 +1897,6 @@ public void markdownMoeComments() { class Test {} """ .replace("moe", "MOE"); - // TODO(kak): Ideally the extra blank lines would not be inserted after the code block String expected = """ /// This is the first line. @@ -1908,8 +1907,6 @@ class Test {} /// ``` /// this is a code block /// ``` - /// - /// /// class Test {} """